Issue 422823008: Explicitly typedef GetUserDefaultLocaleName as WINVER may not be high enough when compiling to allo…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 422823008: Explicitly typedef GetUserDefaultLocaleName as WINVER may not be high enough when compiling to allo… (Closed)

Created:
6 years, 4 months ago by gw280

Modified:
6 years, 4 months ago

Reviewers:
bungeman-skia

CC:
reviews_skia.org, reed1

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Explicitly typedef GetUserDefaultLocaleName as WINVER may not be high enough when compiling to allow visibility of the function prototype in windows.h R=bungeman1 Committed: https://skia.googlesource.com/skia/+/8124bf072c40c2a2a6d58ae19f1951a59dc4757e

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/utils/win/SkDWrite.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

bungeman-skia

lgtm with the WINAPI addition. I really like the decltype since it's so clear, but ...

6 years, 4 months ago (2014-07-29 22:18:00 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/george@mozilla.com/422823008/20001

6 years, 4 months ago (2014-07-30 16:45:31 UTC) #4

commit-bot: I haz the power

6 years, 4 months ago (2014-07-30 16:58:22 UTC) #5

Message was sent while issue was closed.

Change committed as 8124bf072c40c2a2a6d58ae19f1951a59dc4757e