Issue 42280: Made Date parser work on flat strings instead of arbitrary ones.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 42280: Made Date parser work on flat strings instead of arbitrary ones. (Closed)

Created:
11 years, 9 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Visibility:
Public.

Description

Flatten strings before parsing them as Date strings, and work on Vector of chars instead.

Patch Set 1 #

Total comments: 5

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+120 lines, -102 lines)			Patch
M	src/char-predicates-inl.h	View	1 chunk	+11 lines, -9 lines	0 comments	Download
M	src/dateparser.h	View	4 chunks	+90 lines, -6 lines	2 comments	Download
M	src/dateparser.cc	View	4 chunks	+2 lines, -83 lines	1 comment	Download
M	src/runtime.cc	View	1 chunk	+12 lines, -1 line	0 comments	Download
M	test/mjsunit/date-parse.js	View	2 chunks	+5 lines, -3 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

11 years, 9 months ago (2009-03-17 13:09:01 UTC) #2

LGTM.  Can the ARM compiler cope with the templates?

http://codereview.chromium.org/42280/diff/1/3
File src/dateparser.cc (right):

http://codereview.chromium.org/42280/diff/1/3#newcode85
Line 85: 
There should be two blank lines between methods.  Please put them back.

http://codereview.chromium.org/42280/diff/1/4
File src/dateparser.h (right):

http://codereview.chromium.org/42280/diff/1/4#newcode235
Line 235: template <typename Char>
Since the templates force us to move this to a .h file we should probably move
it to an -inl.h file.

http://codereview.chromium.org/42280/diff/1/4#newcode302
Line 302: // TODO(lrn) Is this correct?
I should be possible to find the answer to this and write a test that verifies
it.

http://codereview.chromium.org/42280/diff/1/6
File test/mjsunit/date-parse.js (right):

http://codereview.chromium.org/42280/diff/1/6#newcode44
Line 44: assertTrue(d > 0 && !isNaN(d), string);
This should be two assertions.

http://codereview.chromium.org/42280/diff/1/6#newcode49
Line 49: assertTrue(array.length == 2, "array [" + array + "] length != 2");
This should be assertEquals(2, array.length, ...)

Expand Messages | Collapse Messages