Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1808)

Issue 422793002: Add wfh to some watchlists that are Win64 hotspots. (Closed)

Created:
6 years, 4 months ago by Will Harris
Modified:
6 years, 4 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add wfh to some watchlists that are Win64 hotspots. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286151

Patch Set 1 #

Total comments: 4

Patch Set 2 : 80col #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M WATCHLISTS View 1 7 chunks +15 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Will Harris
PTAL thanks
6 years, 4 months ago (2014-07-28 03:44:14 UTC) #1
Ilya Sherman
LGTM % comments. https://codereview.chromium.org/422793002/diff/1/WATCHLISTS File WATCHLISTS (right): https://codereview.chromium.org/422793002/diff/1/WATCHLISTS#newcode773 WATCHLISTS:773: 'base_allocator': ['dmikurube+memory@chromium.org', 'wfh+watch@chromium.org'], nit: 80-col, please. ...
6 years, 4 months ago (2014-07-28 21:08:43 UTC) #2
Will Harris
This CL is on my laptop at home so I'll fix the 80-col nit and ...
6 years, 4 months ago (2014-07-28 21:11:43 UTC) #3
Will Harris
The CQ bit was checked by wfh@chromium.org
6 years, 4 months ago (2014-07-29 03:59:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/422793002/20001
6 years, 4 months ago (2014-07-29 03:59:47 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_clang_dbg on tryserver.chromium.linux ...
6 years, 4 months ago (2014-07-29 07:33:05 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 09:45:56 UTC) #7
Message was sent while issue was closed.
Change committed as 286151

Powered by Google App Engine
This is Rietveld 408576698