Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 422743002: Deprecate EventSource.URL and WebSocket.URL (Closed)

Created:
6 years, 4 months ago by philipj_slow
Modified:
6 years, 4 months ago
CC:
arv+blink, blink-reviews, blink-reviews-events_chromium.org, Inactive, dglazkov+blink, eae+blinkwatch
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -9 lines) Patch
M LayoutTests/http/tests/eventsource/eventsource-url-attribute-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/http/tests/eventsource/workers/eventsource-url-attribute-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/http/tests/websocket/simple.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/url-attribute-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/http/tests/websocket/url-parsing.html View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/websocket/url-parsing-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/page/EventSource.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/websockets/WebSocket.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
philipj_slow
PTAL
6 years, 4 months ago (2014-07-28 12:40:02 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 4 months ago (2014-07-28 12:41:47 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 4 months ago (2014-07-28 12:43:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/422743002/1
6 years, 4 months ago (2014-07-28 12:44:40 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-07-28 12:47:34 UTC) #5
Message was sent while issue was closed.
Change committed as 179032

Powered by Google App Engine
This is Rietveld 408576698