tests/download_from_google_storage_unittests.py - Issue 42273002: Add a platform filtering and executable setting abilities to download_from_google_storage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/download_from_google_storage_unittests.py

Issue 42273002: Add a platform filtering and executable setting abilities to download_from_google_storage. (Closed) Base URL: http://src.chromium.org/svn/trunk/tools/depot_tools/

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/download_from_google_storage_unittests.py

===================================================================

--- tests/download_from_google_storage_unittests.py (revision 230811)

+++ tests/download_from_google_storage_unittests.py (working copy)

@@ -172,7 +172,7 @@

self.queue.put((None, None))

stdout_queue = Queue.Queue()

download_from_google_storage._downloader_worker_thread(

- 0, self.queue, False, self.base_url, self.gsutil,

+ 0, self.queue, False, self.base_url, self.gsutil, False,

stdout_queue, self.ret_codes)

expected_calls = [

('check_call',

@@ -193,7 +193,7 @@

self.queue.put((None, None))

stdout_queue = Queue.Queue()

download_from_google_storage._downloader_worker_thread(

- 0, self.queue, False, self.base_url, self.gsutil,

+ 0, self.queue, False, self.base_url, self.gsutil, False,

stdout_queue, self.ret_codes)

expected_output = [

'0> File %s exists and SHA1 matches. Skipping.' % output_filename

@@ -210,7 +210,7 @@

stdout_queue = Queue.Queue()

self.gsutil.add_expected(1, '', '') # Return error when 'ls' is called.

download_from_google_storage._downloader_worker_thread(

- 0, self.queue, False, self.base_url, self.gsutil,

+ 0, self.queue, False, self.base_url, self.gsutil, False,

stdout_queue, self.ret_codes)

expected_output = [

'0> File %s for %s does not exist, skipping.' % (

@@ -238,6 +238,7 @@

input_filename=sha1_hash,

base_url=self.base_url,

gsutil=self.gsutil,

+ make_executable=False,

num_threads=1,

directory=False,

recursive=False,

@@ -262,6 +263,7 @@

input_filename=self.base_path,

base_url=self.base_url,

gsutil=self.gsutil,

+ make_executable=False,

num_threads=1,

directory=True,

recursive=False,

« download_from_google_storage.py ('K') | « download_from_google_storage.py ('k') | no next file » | no next file with comments »