Source/core/editing/CompositeEditCommand.cpp - Issue 422693002: Use tighter typing in editing: htmlediting create methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/CompositeEditCommand.cpp

Issue 422693002: Use tighter typing in editing: htmlediting create methods (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/CompositeEditCommand.cpp

diff --git a/Source/core/editing/CompositeEditCommand.cpp b/Source/core/editing/CompositeEditCommand.cpp

index d954114d8ff6efd79813c94e815d6cec92091749..0d0f5d0bceb3fc52763a395750b04a0cdd76b377 100644

--- a/Source/core/editing/CompositeEditCommand.cpp

+++ b/Source/core/editing/CompositeEditCommand.cpp

@@ -66,6 +66,7 @@

#include "core/html/HTMLBRElement.h"

#include "core/html/HTMLDivElement.h"

#include "core/html/HTMLElement.h"

+#include "core/html/HTMLLIElement.h"

#include "core/html/HTMLQuoteElement.h"

#include "core/html/HTMLSpanElement.h"

#include "core/rendering/InlineTextBox.h"

@@ -1304,7 +1305,7 @@ bool CompositeEditCommand::breakOutOfEmptyListItem()

|| listNode == emptyListItem->rootEditableElement())

return false;

- RefPtrWillBeRawPtr<Element> newBlock = nullptr;

+ RefPtrWillBeRawPtr<HTMLElement> newBlock = nullptr;

if (ContainerNode* blockEnclosingList = listNode->parentNode()) {

if (isHTMLLIElement(*blockEnclosingList)) { // listNode is inside another list item

if (visiblePositionAfterNode(*blockEnclosingList) == visiblePositionAfterNode(*listNode)) {

« no previous file with comments | « no previous file | Source/core/editing/InsertListCommand.cpp » ('j') | no next file with comments »