Issue 422683007: Fix jank on resize followed by tab switch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 422683007: Fix jank on resize followed by tab switch. (Closed)

Created:
6 years, 4 months ago by calamity

Modified:
6 years, 4 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fix jank on resize followed by tab switch. This CL fixes an issue where resizing a window and then switching to another tab could cause a frame to render with the WebContentsView at its old size. This is fixed by attaching the new tab at the NativeViewHost's size instead of at the WebContentsView old size. BUG=399420

Patch Set 1 #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	ui/views/controls/native/native_view_host_aura.cc	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sky

6 years, 4 months ago (2014-08-05 16:42:52 UTC) #2

Also, how about test coverage.

https://codereview.chromium.org/422683007/diff/1/ui/views/controls/native/nat...
File ui/views/controls/native/native_view_host_aura.cc (right):

https://codereview.chromium.org/422683007/diff/1/ui/views/controls/native/nat...
ui/views/controls/native/native_view_host_aura.cc:211:
clipping_window_.SetBounds(bounds);
Is there a reason we need to set the bounds here? Can't we wait until we're told
the bounds (ShowWidget)?

Expand Messages | Collapse Messages