Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 422673002: Move BookmarkNodeData into bookmarks namespace. (Closed)

Created:
6 years, 5 months ago by tfarina
Modified:
6 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, extensions-reviews_chromium.org, sadrul, kalyank, tfarina, dcheng, chromium-apps-reviews_chromium.org, ben+aura_chromium.org, James Su, blundell, sdefresne, nshaik
Project:
chromium
Visibility:
Public.

Description

Move BookmarkNodeData into bookmarks namespace. BUG=370433 TEST=None R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286404

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : fix mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -35 lines) Patch
M chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.h View 3 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/aura/tab_contents/web_drag_bookmark_handler_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_drag_drop.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_drag_drop.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_tab_helper.h View 2 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_drag_drop_cocoa.mm View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target.mm View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/web_drag_bookmark_handler_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_drag_drop_views.h View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_drag_drop_views.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/undo/bookmark_undo_service.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/bookmarks/browser/bookmark_client.h View 1 chunk +1 line, -1 line 0 comments Download
M components/bookmarks/browser/bookmark_model.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/bookmarks/browser/bookmark_node_data.h View 2 chunks +4 lines, -0 lines 0 comments Download
M components/bookmarks/browser/bookmark_node_data.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M components/bookmarks/browser/bookmark_node_data_ios.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M components/bookmarks/browser/bookmark_node_data_mac.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M components/bookmarks/browser/bookmark_node_data_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M components/bookmarks/browser/bookmark_node_data_views.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M components/bookmarks/browser/bookmark_pasteboard_helper_mac.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M components/bookmarks/browser/bookmark_pasteboard_helper_mac.mm View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M components/bookmarks/browser/bookmark_storage.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/bookmarks/browser/bookmark_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M components/bookmarks/browser/bookmark_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/bookmarks/browser/bookmark_utils_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
6 years, 5 months ago (2014-07-26 21:28:22 UTC) #1
sky
LGTM
6 years, 4 months ago (2014-07-28 15:00:29 UTC) #2
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 4 months ago (2014-07-30 00:22:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/422673002/40001
6 years, 4 months ago (2014-07-30 00:25:21 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-07-30 03:51:36 UTC) #5
Message was sent while issue was closed. 
Change committed as 286404

Powered by Google App Engine
This is Rietveld 408576698