Add a Clone method to ProofVerifyDetails to allow for the proof verify

net/quic/crypto/quic_crypto_client_config.cc

Index: net/quic/crypto/quic_crypto_client_config.cc
diff --git a/net/quic/crypto/quic_crypto_client_config.cc b/net/quic/crypto/quic_crypto_client_config.cc
index 27d9d060489b1fba4bde17090cf9d88ee06a1800..b39369f08ed323cefa0ab78f8fde915e4c7e4e1d 100644
--- a/net/quic/crypto/quic_crypto_client_config.cc
+++ b/net/quic/crypto/quic_crypto_client_config.cc
@@ -284,6 +284,9 @@ void QuicCryptoClientConfig::CachedState::InitializeFrom(
   certs_ = other.certs_;
   server_config_sig_ = other.server_config_sig_;
   server_config_valid_ = other.server_config_valid_;
+  if (other.proof_verify_details_.get() != NULL) {
+    proof_verify_details_.reset(other.proof_verify_details_->Clone());
+  }

[ramant (doing other things), 2014/07/29 21:40:04]

nit: drive by. Should we consider adding a DCHECK if proof_verify_details_.get()
is NULL then server_config_valid_ is false? thanks.

[Ryan Hamilton, 2014/07/29 21:59:18]

It's worth a shot.  Though there are 2 caveats:
1) The internal proof verifier does not generate proof verify details ever, so
we'd need to implement that. wtc is taking a look at this
2) We don't have proof verify details for insecure QUIC connections. Does the
CachedState know if it's secure? Oh, I guess we could key off of certs being
non-empty?

   ++generation_counter_;
 }