Add a Clone method to ProofVerifyDetails to allow for the proof verify

net/quic/crypto/quic_crypto_client_config.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/crypto/quic_crypto_client_config.h"
 
 #include "base/metrics/histogram.h"
 #include "base/metrics/sparse_histogram.h"
 #include "base/stl_util.h"
 #include "base/strings/string_util.h"
@@ skipping 266 matching lines @@
 
 void QuicCryptoClientConfig::CachedState::InitializeFrom(
     const QuicCryptoClientConfig::CachedState& other) {
   DCHECK(server_config_.empty());
   DCHECK(!server_config_valid_);
   server_config_ = other.server_config_;
   source_address_token_ = other.source_address_token_;
   certs_ = other.certs_;
   server_config_sig_ = other.server_config_sig_;
   server_config_valid_ = other.server_config_valid_;
+  if (other.proof_verify_details_.get() != NULL) {
+    proof_verify_details_.reset(other.proof_verify_details_->Clone());
+  }

[ramant (doing other things), 2014/07/29 21:40:04]

nit: drive by. Should we consider adding a DCHECK if proof_verify_details_.get()
is NULL then server_config_valid_ is false? thanks.

[Ryan Hamilton, 2014/07/29 21:59:18]

It's worth a shot.  Though there are 2 caveats:
1) The internal proof verifier does not generate proof verify details ever, so
we'd need to implement that. wtc is taking a look at this
2) We don't have proof verify details for insecure QUIC connections. Does the
CachedState know if it's secure? Oh, I guess we could key off of certs being
non-empty?

   ++generation_counter_;
 }
 
 void QuicCryptoClientConfig::SetDefaults() {
   // Key exchange methods.
   kexs.resize(2);
   kexs[0] = kC255;
   kexs[1] = kP256;
 
   // Authenticated encryption algorithms. Prefer ChaCha20 by default.
@@ skipping 535 matching lines @@
     return;
   }
 
   // Update canonical version to point at the "most recent" entry.
   canonical_server_map_[suffix_server_id] = server_id;
 
   server_state->InitializeFrom(*canonical_state);
 }
 
 }  // namespace net