test/cctest/test-log-stack-tracer.cc - Issue 422593003: Initial GetSample implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-log-stack-tracer.cc

Issue 422593003: Initial GetSample implementation. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Made the Sample class into an iterable. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-log-stack-tracer.cc

diff --git a/test/cctest/test-log-stack-tracer.cc b/test/cctest/test-log-stack-tracer.cc

index 334a2010532bd3373b7547ede2ff4142ea7988e7..032e0c33c669857dcfa0218349ccae62ee0d33bd 100644

--- a/test/cctest/test-log-stack-tracer.cc

+++ b/test/cctest/test-log-stack-tracer.cc

@@ -64,11 +64,11 @@ static bool IsAddressWithinFuncCode(JSFunction* function, Address addr) {

static bool IsAddressWithinFuncCode(v8::Local<v8::Context> context,

const char* func_name,

- Address addr) {

+ void* addr) {

v8::Local<v8::Value> func = context->Global()->Get(v8_str(func_name));

CHECK(func->IsFunction());

JSFunction* js_func = JSFunction::cast(*v8::Utils::OpenHandle(*func));

- return IsAddressWithinFuncCode(js_func, addr);

+ return IsAddressWithinFuncCode(js_func, static_cast<Address>(addr));

}