Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1759)

Unified Diff: test/cctest/test-log-stack-tracer.cc

Issue 422593003: Initial GetSample implementation. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Removed Address from public API. Removed the function to copy TickSample to Sample. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/test-log-stack-tracer.cc
diff --git a/test/cctest/test-log-stack-tracer.cc b/test/cctest/test-log-stack-tracer.cc
index 334a2010532bd3373b7547ede2ff4142ea7988e7..c604bec24e2071ac25208eae958ac02d74298953 100644
--- a/test/cctest/test-log-stack-tracer.cc
+++ b/test/cctest/test-log-stack-tracer.cc
@@ -176,8 +176,11 @@ TEST(CFromJSStackTrace) {
CHECK_GT(sample.frames_count, base + 1);
CHECK(IsAddressWithinFuncCode(
- context, "JSFuncDoTrace", sample.stack[base + 0]));
- CHECK(IsAddressWithinFuncCode(context, "JSTrace", sample.stack[base + 1]));
+ context, "JSFuncDoTrace",
+ reinterpret_cast<Address>(sample.stack[base + 0])));
+ CHECK(IsAddressWithinFuncCode(
+ context, "JSTrace",
+ reinterpret_cast<Address>(sample.stack[base + 1])));
}
@@ -227,9 +230,12 @@ TEST(PureJSStackTrace) {
// Stack sampling will start from the caller of JSFuncDoTrace, i.e. "JSTrace"
unsigned base = 0;
CHECK_GT(sample.frames_count, base + 1);
- CHECK(IsAddressWithinFuncCode(context, "JSTrace", sample.stack[base + 0]));
CHECK(IsAddressWithinFuncCode(
- context, "OuterJSTrace", sample.stack[base + 1]));
+ context, "JSTrace",
+ reinterpret_cast<Address>(sample.stack[base + 0])));
+ CHECK(IsAddressWithinFuncCode(
+ context, "OuterJSTrace",
+ reinterpret_cast<Address>(sample.stack[base + 1])));
}
« src/sampler.cc ('K') | « test/cctest/cctest.gyp ('k') | test/cctest/test-sampler-api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698