src/log.cc - Issue 422593003: Initial GetSample implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/log.cc

Issue 422593003: Initial GetSample implementation. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed the comments. Fixed the nits. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/log.cc

diff --git a/src/log.cc b/src/log.cc

index 6d88a535dc78f4ce10ce7a578d56d1b7b32b4e7c..97bfe3def0c69ffc843d7fe26a328805a71dbb81 100644

--- a/src/log.cc

+++ b/src/log.cc

@@ -2060,6 +2060,13 @@ bool Logger::SetUp(Isolate* isolate) {

profiler_->Engage();

}

+ // TODO(gholap): This one's for the new sampler API. (include/v8-sampler.h)

+ // Call to IncreaseProfilingDepth causes the

+ // SIGPROF signal handler to be installed on the VM thread.

+ // Figure out whether there's a way to only optionally

+ // do this based on a runtime flag.

+ ticker_->IncreaseProfilingDepth();

if (FLAG_log_internal_timer_events || FLAG_prof) timer_.Start();

return true;