Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Unified Diff: include/v8.h

Issue 422593003: Initial GetSample implementation. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed the comments. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | include/v8-sampler.h » ('j') | include/v8-sampler.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index 73384946ba7d93594fd5c3d78753dfe01c2726f6..766bd9d1fa1b855936a9a307795f91a215a60b38 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -6691,6 +6691,21 @@ void* Context::GetAlignedPointerFromEmbedderData(int index) {
}
+// Logging and profiling. A StateTag represents a possible state of
+// the VM. The logger maintains a stack of these. Creating a VMState
+// object enters a state by pushing on the stack, and destroying a
+// VMState object leaves a state by popping the current state from the
+// stack.
+
+enum StateTag {
Benedikt Meurer 2014/08/14 04:20:23 Move this to v8-sampler.h and fix the comment (VMS
gholap 2014/08/15 17:54:13 Now that you've mentioned it, I've looked into bot
Benedikt Meurer 2014/08/18 04:22:03 Great! We should not expose internal state via the
+ JS, // Executing JavaScript.
+ GC, // Garbage Collection.
+ COMPILER, // Compiling JavaScript.
+ OTHER,
+ EXTERNAL, // External call. (For example, a call into blink)
+ IDLE // The VM is idle.
+};
+
/**
* \example shell.cc
* A simple shell that takes a list of expressions on the
« no previous file with comments | « no previous file | include/v8-sampler.h » ('j') | include/v8-sampler.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698