Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Unified Diff: src/sampler.h

Issue 422593003: Initial GetSample implementation. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Frames count was a bit-field had missed that previously. Now the API actually works. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/sampler.h
diff --git a/src/sampler.h b/src/sampler.h
index c3dce4ed7c2fec7e353cb06d1641f63e82092a84..e55c7be291807ce51a33d620a3fa84e6c4273152 100644
--- a/src/sampler.h
+++ b/src/sampler.h
@@ -32,23 +32,26 @@ struct RegisterState {
struct TickSample {
TickSample()
: state(OTHER),
+ frames_count(0),
pc(NULL),
external_callback(NULL),
- frames_count(0),
has_external_callback(false),
top_frame_type(StackFrame::NONE) {}
- void Init(Isolate* isolate, const RegisterState& state);
- StateTag state; // The state of the VM.
+ static const unsigned kMaxFramesCountLog2 = 8;
+ static const unsigned kMaxFramesCount = (1 << kMaxFramesCountLog2) - 1;
+
+ StateTag state; // The state of the VM.
+ Address stack[kMaxFramesCount]; // Call stack.
+ unsigned frames_count : kMaxFramesCountLog2; // Number of captured frames.
+
+ void Init(Isolate* isolate,
+ const RegisterState& state);
Address pc; // Instruction pointer.
union {
Address tos; // Top stack value (*sp).
Address external_callback;
};
- static const unsigned kMaxFramesCountLog2 = 8;
- static const unsigned kMaxFramesCount = (1 << kMaxFramesCountLog2) - 1;
- Address stack[kMaxFramesCount]; // Call stack.
base::TimeTicks timestamp;
- unsigned frames_count : kMaxFramesCountLog2; // Number of captured frames.
bool has_external_callback : 1;
StackFrame::Type top_frame_type : 4;
};
@@ -85,6 +88,7 @@ class Sampler {
bool IsActive() const { return base::NoBarrier_Load(&active_); }
void DoSample();
+ TickSample* GetSample(TickSample* sample);
// If true next sample must be initiated on the profiler event processor
// thread right after latest sample is processed.
void SetHasProcessingThread(bool value) {
@@ -120,6 +124,7 @@ class Sampler {
bool is_counting_samples_;
// Counts stack samples taken in JS VM state.
unsigned js_and_external_sample_count_;
+ TickSample* GetSampleHelper_();
DISALLOW_IMPLICIT_CONSTRUCTORS(Sampler);
};

Powered by Google App Engine
This is Rietveld 408576698