Initial GetSample implementation.

src/log.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdarg.h>
 
 #include "src/v8.h"
 
 #include "src/base/platform/platform.h"
 #include "src/bootstrapper.h"
@@ skipping 1517 matching lines @@
   } else {
     msg.Append(",0,");
     msg.AppendAddress(sample->tos);
   }
   msg.Append(",%d", static_cast<int>(sample->state));
   if (overflow) {
     msg.Append(",overflow");
   }
   for (unsigned i = 0; i < sample->frames_count; ++i) {
     msg.Append(',');
-    msg.AppendAddress(sample->stack[i]);
+    msg.AppendAddress(static_cast<Address>(sample->stack[i]));
   }
   msg.WriteToLogFile();
 }
 
 
 void Logger::StopProfiler() {
   if (!log_->IsEnabled()) return;
   if (profiler_ != NULL) {
     profiler_->pause();
     is_logging_ = false;
@@ skipping 313 matching lines @@
   if (Log::InitLogAtStart()) {
     is_logging_ = true;
   }
 
   if (FLAG_prof) {
     profiler_ = new Profiler(isolate);
     is_logging_ = true;
     profiler_->Engage();
   }
 
+  // TODO(gholap): This one's for the new sampler API. (include/v8-sampler.h)

[yurys, 2014/09/09 14:35:20]

There is no include/v8-sampler.h

[gholap, 2014/09/17 02:35:06]

Done.

+  //               Call to IncreaseProfilingDepth causes the
+  //               SIGPROF signal handler to be installed on the VM thread.
+  //               Figure out whether there's a way to only optionally
+  //               do this based on a runtime flag.
+  ticker_->IncreaseProfilingDepth();

[yurys, 2014/09/09 14:35:20]

This breaks the invariant as now Sampler::IsProfiling will always return true.
Doing this unconditionally is weird. We shouldn't need SIGPROF handler unless
profiler is on. Having thread state passed into v8::Isolate::GetSample as
described in the document would help to avoid such issues.

[gholap, 2014/09/17 02:35:06]

Done.

+
   if (FLAG_log_internal_timer_events || FLAG_prof) timer_.Start();
 
   return true;
 }
 
 
 void Logger::SetCodeEventHandler(uint32_t options,
                                  JitCodeEventHandler event_handler) {
   if (jit_logger_) {
       removeCodeEventListener(jit_logger_);
@@ skipping 53 matching lines @@
   if (jit_logger_) {
     removeCodeEventListener(jit_logger_);
     delete jit_logger_;
     jit_logger_ = NULL;
   }
 
   return log_->Close();
 }
 
 } }  // namespace v8::internal