Initial GetSample implementation.

include/v8-sampler.h

+// Copyright 2014 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef V8_V8_SAMPLER_H_
+#define V8_V8_SAMPLER_H_
+
+#include "v8.h"
+
+/**
+ * Sampler API for the V8 JavaScript engine.
+ * The API to be consumed by any code which
+ * wants to build a sampling profiler for v8.
+ */
+namespace v8 {
+  /* TODO(gholap): Find a better way of doing this? */
+  typedef unsigned char* Address;
+
+/**
+ * VMState indicates what action the VM is performing during that state.
+ */
+enum VMState {
+  JS,              // Executing JavaScript.
+  GC,              // Garbage Collection.
+  COMPILER,        // Compiling JavaScript.
+  OTHER,
+  EXTERNAL,        // External call. (For example, a call into blink)
+  IDLE             // The VM is idle.
+};
+
+/**
+ * A collected sample contains,
+ * - state       : The state of the VM at the time of collecting the sample.
+ * - stack       : An array of addresses.
+ *                 One address per stack frame.
+ *                 The address is the instruction pointer,
+ *                 pointing to the instruction which led to the
+ *                 creation of the stack frame.
+ *                 (for example, a function call)
+ * - frames_count: Number of stack frames that were captured.
+ *                 That is, stack[frames_count+i] might contain meaningless
+ *                 addresses for any i >= 0.
+ */
+struct Sample {
+  static const unsigned kMaxFramesCountLog2 = 8;
+  static const unsigned kMaxFramesCount = (1 << kMaxFramesCountLog2) - 1;
+
+  VMState state;                     // The state of the VM.
+  Address stack[kMaxFramesCount];    // Call stack.
+  unsigned frames_count;             // Number of captured frames.
+};
+
+/**
+ * Interface for collecting execution stack samples.
+ */
+class V8_EXPORT Sampler {
+ public:
+  /**
+   * Obtain a sample from the isolate.
+   */
+  static void GetSample(Isolate* isolate,
+                        unsigned max_frame_count,

[fmeawad, 2014/07/29 18:30:50]

I would suggest removing that, currently the stack size is at 255 which is small
enough.

+                        Sample* sample);
+};
+}  // namespace v8
+#endif  // V8_V8_SAMPLER_H_