Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 422583002: Test that simulates touch exploration on the system tray and checks speech. (Closed)

Created:
6 years, 5 months ago by dmazzoni
Modified:
6 years, 5 months ago
Reviewers:
evy1, evy, aboxhall
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Test that simulates touch exploration on the system tray and checks speech. BUG=392666 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285817

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove printfs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -0 lines) Patch
M chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc View 1 5 chunks +39 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
dmazzoni
6 years, 5 months ago (2014-07-25 21:47:57 UTC) #1
evy1
Other than the print statements, lgtm https://codereview.chromium.org/422583002/diff/1/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc File chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc (right): https://codereview.chromium.org/422583002/diff/1/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc#newcode236 chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:236: Whoops - you ...
6 years, 5 months ago (2014-07-25 22:02:13 UTC) #2
dmazzoni
Thanks! +aboxhall for review from a full committer https://codereview.chromium.org/422583002/diff/1/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc File chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc (right): https://codereview.chromium.org/422583002/diff/1/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc#newcode236 chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:236: On ...
6 years, 5 months ago (2014-07-25 22:05:22 UTC) #3
aboxhall
lgtm Rubberstamp LGTM
6 years, 5 months ago (2014-07-25 22:07:16 UTC) #4
dmazzoni
The CQ bit was checked by dmazzoni@chromium.org
6 years, 5 months ago (2014-07-25 22:10:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/422583002/20001
6 years, 5 months ago (2014-07-25 22:13:44 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 5 months ago (2014-07-25 23:40:20 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-26 00:10:07 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/33012)
6 years, 5 months ago (2014-07-26 00:10:08 UTC) #9
dmazzoni
The CQ bit was checked by dmazzoni@chromium.org
6 years, 5 months ago (2014-07-26 21:46:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/422583002/20001
6 years, 5 months ago (2014-07-26 21:47:00 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium.linux ...
6 years, 5 months ago (2014-07-26 22:33:03 UTC) #12
commit-bot: I haz the power
6 years, 5 months ago (2014-07-26 23:23:22 UTC) #13
Message was sent while issue was closed.
Change committed as 285817

Powered by Google App Engine
This is Rietveld 408576698