Add way to remove entries from autocomplete

Pressing the Del key while a item is selected in the autocomplete popup deletes that suggestion from the DB.

BUG=6176
TEST=Bring up the autofill popup in a form. Select an item and press the Del key. The item should be removed from the popup and should not show on subsequent autofill popups.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12221

[jcampan, 2009-03-19 18:09:53]

I implemented this before the associated bug was deferred to 3.0.
Since it is ready, I figure I should get it in.

[sky, 2009-03-19 18:30:49]

http://codereview.chromium.org/42258/diff/36/42
File chrome/browser/webdata/web_database.cc (right):

http://codereview.chromium.org/42258/diff/36/42#newcode1174
Line 1174: return s.step() != SQLITE_DONE;
Any reason you don't want to use the remove method? It helps prevent bugs like
you're about to introduce. This should be s2.step.

http://codereview.chromium.org/42258/diff/36/38
File webkit/glue/webview_impl.cc (right):

http://codereview.chromium.org/42258/diff/36/38#newcode268
Line 268: DCHECK_LT(index, static_cast<int>(suggestions_.size()));
This DCHECK would miss a value < 0.

[jcampan, 2009-03-19 18:48:15]

http://codereview.chromium.org/42258/diff/36/42
File chrome/browser/webdata/web_database.cc (right):

http://codereview.chromium.org/42258/diff/36/42#newcode1174
Line 1174: return s.step() != SQLITE_DONE;
On 2009/03/19 18:30:49, sky wrote:
> Any reason you don't want to use the remove method? It helps prevent bugs like
> you're about to introduce. This should be s2.step.
I thought it would be better to not compare dates since we don't care about
them, but I guess it does not save much anyway. Reverted to using
RemoveFormElementForTimeRange.

http://codereview.chromium.org/42258/diff/36/38
File webkit/glue/webview_impl.cc (right):

http://codereview.chromium.org/42258/diff/36/38#newcode268
Line 268: DCHECK_LT(index, static_cast<int>(suggestions_.size()));
On 2009/03/19 18:30:49, sky wrote:
> This DCHECK would miss a value < 0.

Now catching negative values as well.

[sky, 2009-03-19 18:53:43]

LGTM