Prevented false error messages from user manager UI.

ui/login/account_picker/user_pod_row.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview User pod row implementation.
  */
 
 cr.define('login', function() {
   /**
@@ skipping 46 matching lines @@
   var DESKTOP_ROW_PADDING = 15;
 
   /**
    * Minimal padding between user pod and virtual keyboard.
    * @type {number}
    * @const
    */
   var USER_POD_KEYBOARD_MIN_PADDING = 20;
 
   /**
-   * Whether to preselect the first pod automatically on login screen.
-   * @type {boolean}
-   * @const
-   */
-  var PRESELECT_FIRST_POD = true;
-
-  /**
    * Maximum time for which the pod row remains hidden until all user images
    * have been loaded.
    * @type {number}
    * @const
    */
   var POD_ROW_IMAGES_LOAD_TIMEOUT_MS = 3000;
 
   /**
    * Public session help topic identifier.
    * @type {number}
@@ skipping 1611 matching lines @@
       if (this.shouldShowApps_) {
         for (var i = 0; i < this.apps_.length; ++i)
           this.addUserPod(this.apps_[i]);
       }
 
       // Make sure we eventually show the pod row, even if some image is stuck.
       setTimeout(function() {
         $('pod-row').classList.remove('images-loading');
       }, POD_ROW_IMAGES_LOAD_TIMEOUT_MS);
 
-      var isCrosAccountPicker = $('login-header-bar').signinUIState ==
+      var isAccountPicker = $('login-header-bar').signinUIState ==
           SIGNIN_UI_STATE.ACCOUNT_PICKER;
-      var isDesktopUserManager = Oobe.getInstance().displayType ==
-          DISPLAY_TYPE.DESKTOP_USER_MANAGER;
 
-      // Chrome OS: immediately recalculate pods layout only when current UI
-      //            is account picker. Otherwise postpone it.
-      // Desktop: recalculate pods layout right away.
-      if (isDesktopUserManager || isCrosAccountPicker) {
+      // Immediately recalculate pods layout only when current UI is account
+      // picker. Otherwise postpone it.
+      if (isAccountPicker) {
         this.placePods_();
+        this.maybePreselectPod();
 
         // Without timeout changes in pods positions will be animated even
         // though it happened when 'flying-pods' class was disabled.
         setTimeout(function() {
           Oobe.getInstance().toggleClass('flying-pods', true);
         }, 0);
-
-        // On desktop, don't pre-select a pod if it's the only one.
-        if (isDesktopUserManager && this.pods.length == 1)
-          this.focusPod();
-        else
-          this.focusPod(this.preselectedPod);
       } else {
         this.podPlacementPostponed_ = true;
 
         // Update [Cancel] button state.
         if ($('login-header-bar').signinUIState ==
                 SIGNIN_UI_STATE.GAIA_SIGNIN &&
             emptyPodRow &&
             this.pods.length > 0) {
           login.GaiaSigninScreen.updateCancelButtonState();
         }
@@ skipping 194 matching lines @@
       var maxPodsNumber = columns * rows;
       var isDesktopUserManager = Oobe.getInstance().displayType ==
           DISPLAY_TYPE.DESKTOP_USER_MANAGER;
       var margin = isDesktopUserManager ? DESKTOP_MARGIN_BY_COLUMNS[columns] :
                                           MARGIN_BY_COLUMNS[columns];
       this.parentNode.setPreferredSize(
           this.columnsToWidth_(columns), this.rowsToHeight_(rows));
       var height = this.userPodHeight_;
       var width = this.userPodWidth_;
       this.pods.forEach(function(pod, index) {
+        if (index >= maxPodsNumber) {
+           pod.hidden = true;
+           return;
+        }
+        pod.hidden = false;
         if (pod.offsetHeight != height) {
           console.error('Pod offsetHeight (' + pod.offsetHeight +
               ') and POD_HEIGHT (' + height + ') are not equal.');
         }
         if (pod.offsetWidth != width) {
           console.error('Pod offsetWidth (' + pod.offsetWidth +
               ') and POD_WIDTH (' + width + ') are not equal.');
         }
-        if (index >= maxPodsNumber) {
-           pod.hidden = true;
-           return;
-        }
-        pod.hidden = false;
         var column = index % columns;
         var row = Math.floor(index / columns);
         var rowPadding = isDesktopUserManager ? DESKTOP_ROW_PADDING :
                                                 POD_ROW_PADDING;
         pod.left = rowPadding + column * (width + margin);
 
         // On desktop, we want the rows to always be equally spaced.
         pod.top = isDesktopUserManager ? row * (height + rowPadding) :
                                          row * height + rowPadding;
       });
@@ skipping 148 matching lines @@
           return pod;
       }
       return null;
     },
 
     /**
      * The pod that is preselected on user pod row show.
      * @type {?UserPod}
      */
     get preselectedPod() {
+      // On desktop, don't pre-select a pod if it's the only one.
+      var isDesktopUserManager = Oobe.getInstance().displayType ==
+          DISPLAY_TYPE.DESKTOP_USER_MANAGER;
+      if (isDesktopUserManager && this.pods.length == 1)
+        return null;
+
       var lockedPod = this.lockedPod;
-      if (lockedPod || !PRESELECT_FIRST_POD)
+      if (lockedPod)
         return lockedPod;
       for (var i = 0, pod; pod = this.pods[i]; ++i) {
         if (!pod.multiProfilesPolicyApplied) {
           return pod;
         }
       }
       return this.pods[0];
     },
 
     /**
@@ skipping 236 matching lines @@
       Oobe.getInstance().toggleClass('flying-pods', false);
       for (var event in this.listeners_) {
         this.ownerDocument.addEventListener(
             event, this.listeners_[event][0], this.listeners_[event][1]);
       }
       $('login-header-bar').buttonsTabIndex = UserPodTabOrder.HEADER_BAR;
 
       if (this.podPlacementPostponed_) {
         this.podPlacementPostponed_ = false;
         this.placePods_();
-        pod = this.preselectedPod;
-        this.focusPod(pod);
-        // Hide user-type-bubble in case all user pods are disabled and we focus
-        // first pod.
-        if (pod && pod.multiProfilesPolicyApplied) {
-          pod.userTypeBubbleElement.classList.remove('bubble-shown');
-        }
+        this.maybePreselectPod();
       }
     },
 
     /**
      * Called when the element is hidden.
      */
     handleHide: function() {
       for (var event in this.listeners_) {
         this.ownerDocument.removeEventListener(
             event, this.listeners_[event][0], this.listeners_[event][1]);
       }
       $('login-header-bar').buttonsTabIndex = 0;
     },
 
     /**
      * Called when a pod's user image finishes loading.
      */
     handlePodImageLoad: function(pod) {
       var index = this.podsWithPendingImages_.indexOf(pod);
       if (index == -1) {
         return;
       }
 
       this.podsWithPendingImages_.splice(index, 1);
       if (this.podsWithPendingImages_.length == 0) {
         this.classList.remove('images-loading');
       }
-    }
+    },
+
+    /**
+     * Preselects pod, if needed.
+     */
+     maybePreselectPod: function() {
+       var pod = this.preselectedPod;
+       this.focusPod(pod);
+
+       // Hide user-type-bubble in case all user pods are disabled and we focus
+       // first pod.
+       if (pod && pod.multiProfilesPolicyApplied) {
+         pod.userTypeBubbleElement.classList.remove('bubble-shown');
+       }
+     }
   };
 
   return {
     PodRow: PodRow
   };
 });