Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Issue 422563002: Prevented false error messages from user manager UI. (Closed)

Created:
6 years, 4 months ago by dzhioev (left Google)
Modified:
6 years, 4 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Prevented false error messages from user manager UI. Messages like "Pod offsetHeight (0) and POD_HEIGHT (226) are not equal." were reported on desktop user manager. It happened because |placePods_| method call were made, when account picker was hidden. In addition deprecated |webkitRequestAnimationFrame| was replaced with |requestAnimationFrame| in login code. BUG=none TEST=Run user manager, see that messages are gone. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287407

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -45 lines) Patch
M chrome/browser/resources/chromeos/login/demo_user_login.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/screen_gaia_signin.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/user_manager/control_bar.js View 1 2 3 chunks +6 lines, -2 lines 0 comments Download
M ui/login/account_picker/screen_account_picker.js View 1 2 2 chunks +1 line, -7 lines 0 comments Download
M ui/login/account_picker/user_pod_row.js View 1 2 7 chunks +33 lines, -34 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
dzhioev (left Google)
Hi, PTAL.
6 years, 4 months ago (2014-07-25 18:31:41 UTC) #1
Nikita (slow)
Please rebase with https://codereview.chromium.org/402403005/
6 years, 4 months ago (2014-07-25 19:46:32 UTC) #2
Nikita (slow)
lgtm, thanks
6 years, 4 months ago (2014-07-25 19:51:30 UTC) #3
dzhioev (left Google)
On 2014/07/25 19:51:30, Nikita Kostylev wrote: > lgtm, thanks Monica, ping.
6 years, 4 months ago (2014-08-01 13:07:30 UTC) #4
noms (inactive)
lgtm
6 years, 4 months ago (2014-08-01 15:43:52 UTC) #5
dzhioev (left Google)
The CQ bit was checked by dzhioev@chromium.org
6 years, 4 months ago (2014-08-01 16:09:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dzhioev@chromium.org/422563002/20001
6 years, 4 months ago (2014-08-01 16:11:26 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-01 20:08:11 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-01 20:10:49 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/47288) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/36582) android_aosp ...
6 years, 4 months ago (2014-08-01 20:10:50 UTC) #10
dzhioev (left Google)
The CQ bit was checked by dzhioev@chromium.org
6 years, 4 months ago (2014-08-04 16:10:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dzhioev@chromium.org/422563002/40001
6 years, 4 months ago (2014-08-04 16:10:33 UTC) #12
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 00:01:28 UTC) #13
Message was sent while issue was closed.
Change committed as 287407

Powered by Google App Engine
This is Rietveld 408576698