Add `CheckObjectCoercible` for the `String.prototype` HTML methods

Add `CheckObjectCoercible` for the `String.prototype` HTML methods

Contributed by Mathias Bynens <mathiasb@opera.com>;.

TEST=mjsunit/es6/string-html
BUG=v8:2218
LOG=Y
R=yangguo@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=22938

[mathiasb, 2014-08-05 05:43:14]

Note that this patch also contains the (few) commented-out tests for V8 issue
2217 (since the tests are a 1:1 copy of
<http://mathias.html5.org/tests/javascript/string/>). Once this lands, I’ll
upload a new patch for issue 2217.

PTAL.

[Yang, 2014-08-05 10:34:19]

Looking good.

https://codereview.chromium.org/422543003/diff/1/src/string.js
File src/string.js (right):

https://codereview.chromium.org/422543003/diff/1/src/string.js#newcode842
src/string.js:842: CHECK_OBJECT_COERCIBLE(this, "String.prototype.link");
Now that all of this is specified in ES6, do you mind adding the references to
the sections in the ES6 draft (including draft date)?

https://codereview.chromium.org/422543003/diff/1/test/mjsunit/string-html.js
File test/mjsunit/string-html.js (right):

https://codereview.chromium.org/422543003/diff/1/test/mjsunit/string-html.js#...
test/mjsunit/string-html.js:4: 
Since this is not specified until es6, could you move this to test/mjsunit/es6/?

https://codereview.chromium.org/422543003/diff/1/test/mjsunit/string-html.js#...
test/mjsunit/string-html.js:66:
assertEquals(String.prototype.fontcolor.call(0x2A, 0x2A), '<font
color="42">42</font>');
please honor the 80-char limit.

[mathiasb, 2014-08-05 11:09:17]

Thanks for the review. I’ve updated the patch. PTAL.

[rossberg, 2014-08-05 11:15:29]

https://codereview.chromium.org/422543003/diff/20001/src/string.js
File src/string.js (right):

https://codereview.chromium.org/422543003/diff/20001/src/string.js#newcode709
src/string.js:709: // ES6 draft 07-18-14, section B.2.3.1
Drive-by: please use ISO date order. Or in this case, perhaps spec revision
number is more adequate.

[aandrey, 2014-08-05 11:16:20]

https://codereview.chromium.org/422543003/diff/20001/src/string.js
File src/string.js (right):

https://codereview.chromium.org/422543003/diff/20001/src/string.js#newcode872
src/string.js:872: 
one more blank line

[mathiasb, 2014-08-05 11:18:11]

On 2014/08/05 at 11:15:29, rossberg wrote:
> https://codereview.chromium.org/422543003/diff/20001/src/string.js
> File src/string.js (right):
> 
> https://codereview.chromium.org/422543003/diff/20001/src/string.js#newcode709
> src/string.js:709: // ES6 draft 07-18-14, section B.2.3.1
> Drive-by: please use ISO date order. Or in this case, perhaps spec revision
number is more adequate.

FTR, I used this format because that’s being used in harmony-string.js. I’ll
update the patch.

[mathiasb, 2014-08-05 11:25:41]

Thanks rossberg and aandrey! Patch updated. PTAL.

[Yang, 2014-08-05 12:57:01]

On 2014/08/05 11:25:41, mathiasb wrote:
> Thanks rossberg and aandrey! Patch updated. PTAL.

LGTM. Will land soon unless further comments.

[Yang, 2014-08-06 14:58:53]

Committed patchset #3 manually as 22938 (presubmit successful).