Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(892)

Issue 422533005: Add missing blink files to the GN build. (Closed)

Created:
6 years, 5 months ago by brettw
Modified:
6 years, 5 months ago
Reviewers:
haraken, jamesr
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Project:
blink
Visibility:
Public.

Description

Add missing blink files to the GN build. TBR=jamesr Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178953

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M Source/bindings/core/v8/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/BUILD.gn View 3 chunks +6 lines, -1 line 0 comments Download
M Source/core/core.gyp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
brettw
6 years, 5 months ago (2014-07-25 18:06:08 UTC) #1
brettw
The CQ bit was checked by brettw@chromium.org
6 years, 5 months ago (2014-07-25 18:06:11 UTC) #2
jamesr
lgtm
6 years, 5 months ago (2014-07-25 18:06:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/422533005/1
6 years, 5 months ago (2014-07-25 18:06:56 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-25 19:08:09 UTC) #5
commit-bot: I haz the power
Change committed as 178953
6 years, 5 months ago (2014-07-25 20:14:42 UTC) #6
haraken
6 years, 5 months ago (2014-07-25 22:45:37 UTC) #7
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698