Fix Regression in Unpacked Extension Load Error UI

chrome/browser/resources/extensions/extension_loader.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('extensions', function() {
   'use strict';
 
   /**
    * Construct an ExtensionLoadError around the given |div|.
    * @param {HTMLDivElement} div The HTML div for the extension load error.
    * @constructor
    */
   function ExtensionLoadError(div) {
     div.__proto__ = ExtensionLoadError.prototype;
     div.init();
     return div;
   }
 
   /**
    * Construct a Failure.
    * @param {string} filePath The path to the unpacked extension.
-   * @param {string} reason The reason the extension failed to load.
+   * @param {string} error The reason the extension failed to load.
    * @param {Object} manifest An object with three strings: beforeHighlight,
    *     afterHighlight, and highlight. These represent three portions of the
    *     file's content to display - the portion which is most relevant and
    *     should be emphasized (highlight), and the parts both before and after
    *     this portion. These may be empty.
    * @param {HTMLLIElement} listElement The HTML element used for displaying the
    *     failure path for the additional failures UI.
    * @constructor
    */
-  function Failure(filePath, reason, manifest, listElement) {
+  function Failure(filePath, error, manifest, listElement) {
     this.path = filePath;
-    this.reason = reason;
+    this.error = error;
     this.manifest = manifest;
     this.listElement = listElement;
   }
 
   ExtensionLoadError.prototype = {
     __proto__: HTMLDivElement.prototype,
 
     /**
      * Initialize the ExtensionLoadError div.
      */
@@ skipping 54 matching lines @@
      * Add a failure to failures_ array. If there is already a displayed
      * failure, display the additional failures element.
      * @param {Array.<Object>} failures Array of failures containing paths,
      *     errors, and manifests.
      * @private
      */
     add_: function(failures) {
       // If a failure is already being displayed, unhide the last item.
       if (this.failures_.length > 0)
         this.failures_[this.failures_.length - 1].listElement.hidden = false;
-      for (var i = 0; i < failures.length; ++i) {
+      failures.forEach(function(failure) {
         var listItem = document.createElement('li');
-        listItem.textContent = failures[i].path;
+        listItem.textContent = failure.path;
         this.additional_.list.appendChild(listItem);
-        failures[i].listElement = listItem;
-        this.failures_.push(failures[i]);
-      }
+        this.failures_.push(new Failure(failure.path,
+                                        failure.error,
+                                        failure.manifest,
+                                        listItem));
+      }.bind(this));
       // Hide the last item because the UI is displaying its information.
       this.failures_[this.failures_.length - 1].listElement.hidden = true;
       this.show_();
     },
 
     /**
      * Remove a failure from |failures_| array. If this was the last failure,
      * hide the error UI.  If this was the last additional failure, hide
      * the additional failures UI.
      * @private
@@ skipping 13 matching lines @@
     /**
      * Display the load error to the user. The last failure gets its manifest
      * and error displayed, while additional failures have their path names
      * displayed in the additional failures element.
      * @private
      */
     show_: function() {
       assert(this.failures_.length >= 1);
       var failure = this.failures_[this.failures_.length - 1];
       this.path_.textContent = failure.path;
-      this.reason_.textContent = failure.reason;
+      this.reason_.textContent = failure.error;
 
-      failure.manifest.message = failure.reason;
+      failure.manifest.message = failure.error;
       this.manifest_.populate(
           failure.manifest,
           loadTimeData.getString('extensionLoadCouldNotLoadManifest'));
       this.hidden = false;
       this.manifest_.scrollToError();
 
       this.additional_.hidden = this.failures_.length == 1;
     }
   };
 
@@ skipping 40 matching lines @@
    * @see ExtensionLoader.notifyFailed
    */
   ExtensionLoader.notifyLoadFailed = function(failures) {
     ExtensionLoader.getInstance().notifyFailed(failures);
   };
 
   return {
     ExtensionLoader: ExtensionLoader
   };
 });