Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Side by Side Diff: remoting/host/window_capturer_screen_wrapper.cc

Issue 422503004: Adding ability to stream windows and inject events to them (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: I updated the code with almost all of the comments Lambros had. The exceptions are the redesign of … Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "remoting/host/window_capturer_screen_wrapper.h"
6
7 namespace remoting {
8
9 WindowCapturerScreenWrapper::WindowCapturerScreenWrapper() {
Wez 2014/08/01 23:41:55 You're not initializing the |window_capturer_| bar
ronakvora do not use 2014/08/05 19:54:50 Changed to scoped_ptr.
10 }
11
12 WindowCapturerScreenWrapper::~WindowCapturerScreenWrapper() {
13 }
14
15 bool WindowCapturerScreenWrapper::SelectWindow
16 (webrtc::WindowCapturer::WindowId id) {
17 return window_capturer_->SelectWindow(id);
18 }
19 void WindowCapturerScreenWrapper::SetWindow
20 (const webrtc::DesktopCaptureOptions& options) {
21 window_capturer_ = webrtc::WindowCapturer::Create(options);
22 }
23
24 void WindowCapturerScreenWrapper::Start(Callback* callback) {
25 window_capturer_->Start(callback);
Wez 2014/08/01 23:41:55 When you switch |window_capturer_| to scoped_ptr<>
ronakvora do not use 2014/08/05 19:54:50 Got it.
26 }
27
28 void WindowCapturerScreenWrapper::Capture(const webrtc::DesktopRegion& region) {
29 window_capturer_->Capture(region);
30 }
31
32 void WindowCapturerScreenWrapper::SetMouseShapeObserver(
33 MouseShapeObserver* mouse_shape_observer) {
Wez 2014/08/01 23:41:55 NOTIMPLEMENTED();
ronakvora do not use 2014/08/05 19:54:50 This method gets called since we're using it as a
34 return;
35 }
36 bool WindowCapturerScreenWrapper::GetScreenList(ScreenList* screens) {
Wez 2014/08/01 23:41:55 NOTIMPLENTED();
ronakvora do not use 2014/08/05 19:54:50 Even though it returns a boolean?
37 return false;
38 }
39
40 bool WindowCapturerScreenWrapper::SelectScreen(webrtc::ScreenId id) {
Wez 2014/08/01 23:41:55 NOTIMPLEMENTED();
ronakvora do not use 2014/08/05 19:54:50 Even though it returns a boolean?
41 return false;
42 }
43
44 } // namespace remoting
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698