Adding ability to stream windows and inject events to them

remoting/host/input_injector.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_HOST_INPUT_INJECTOR_H_
 #define REMOTING_HOST_INPUT_INJECTOR_H_
 
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "remoting/protocol/clipboard_stub.h"
 #include "remoting/protocol/input_stub.h"
-
+#include "third_party/webrtc/modules/desktop_capture/desktop_capture_types.h"
 namespace base {
 class SingleThreadTaskRunner;
 }  // namespace base
 
 namespace remoting {
 
 class InputInjector : public protocol::ClipboardStub,
                       public protocol::InputStub {
  public:
   // Creates a default input injector for the current platform. This
   // object should do as much work as possible on |main_task_runner|,
   // using |ui_task_runner| only for tasks actually requiring a UI
   // thread.
   static scoped_ptr<InputInjector> Create(
       scoped_refptr<base::SingleThreadTaskRunner> main_task_runner,
       scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner);
 
+  // This method is used to create an InputInjector that is
+  // used to input events to a window instead of a screen.
+  // See remoting::InputInjectorMac::InjectMouseEvent for
+  // an example of how the extra parameters get used.
+  static scoped_ptr<InputInjector> CreateForWindow(
+      scoped_refptr<base::SingleThreadTaskRunner> main_task_runner,
+      scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner,
+      webrtc::WindowId window_id);

[Wez, 2014/08/01 23:41:53]

All your windowed input-injection implementation does is find the top-left
corner of the window and adjust the input event coordinates accordingly.

You can break that out into a separate WindowedInputInjector that creates an
InputInjector internally and just proxies ClipboardStub and InputStub APIs back
and forth (that bit is an annoying artefact of InputInjector bundling both APIs
into one object - you should be able to use InputFilter for this instead ): and
adjusts the mouse coordinates before passing them on to the real InputInjector.

[Wez, 2014/08/01 23:41:53]

InputInjector is an interface; you can pull the input injection implementation
for windows out to a separate header/implementation file.

[ronakvora do not use, 2014/08/05 19:54:49]

Done.

[ronakvora do not use, 2014/08/05 19:54:49]

Done.

+
   // Initialises any objects needed to execute events.
   virtual void Start(
       scoped_ptr<protocol::ClipboardStub> client_clipboard) = 0;
+
+  // Enables capturing of a window and gives the id of the window
+  // that needs to be captured.
+  void EnableWindowInjection(webrtc::WindowId window_id);

[Wez, 2014/08/01 23:41:53]

Looks like this got here by mistake?

[ronakvora do not use, 2014/08/05 19:54:49]

I use this in the CreateForWindow method; I think it needs to be public? Should
it just only be declared in the cc?

 };
 
 }  // namespace remoting
 
 #endif  // REMOTING_HOST_INPUT_INJECTOR_H_