Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 422493002: Update third_party/cld_2 to r163 for simplified headers (Closed)

Created:
6 years, 5 months ago by Andrew Hayden (chromium.org)
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Update third_party/cld_2 to r163 for simplified headers This change makes the CLD2 header files ok to use regardless of whether or not the CLD2_DYNAMIC_MODE define is set when including them. No-op implementations have been added to the C++ code in CLD2 for the cases where client code incorrectly calls dynamic-mode methods with a non-dynamic build of the library. This allows including projects (such as Chromium) to opt for runtime checks instead of compile-time checks when dealing with CLD2, which in turn greatly simplifies the build logic for code that depends on CLD2. BUG=367239 TBR=toyoshim Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285581

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Andrew Hayden (chromium.org)
See crbug/367239 for an explanation of why we are doing this.
6 years, 5 months ago (2014-07-25 11:01:29 UTC) #1
Andrew Hayden (chromium.org)
The CQ bit was checked by andrewhayden@chromium.org
6 years, 5 months ago (2014-07-25 12:36:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andrewhayden@chromium.org/422493002/1
6 years, 5 months ago (2014-07-25 12:37:18 UTC) #3
commit-bot: I haz the power
Change committed as 285581
6 years, 5 months ago (2014-07-25 13:14:17 UTC) #4
Takashi Toyoshima
6 years, 4 months ago (2014-07-28 16:24:08 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698