Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: chrome/installer/setup/install.cc

Issue 422453004: Remove some dead app host code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: added TODO to fix app list active user tracking key management Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/setup/install.cc
diff --git a/chrome/installer/setup/install.cc b/chrome/installer/setup/install.cc
index 05e5b9bca67ec572fe3f866f8a1d36aee4cd0e9e..0d706f324748d2c19d2e717ea41ab038aa0bf9fd 100644
--- a/chrome/installer/setup/install.cc
+++ b/chrome/installer/setup/install.cc
@@ -17,7 +17,6 @@
#include "base/memory/scoped_ptr.h"
#include "base/numerics/safe_conversions.h"
#include "base/path_service.h"
-#include "base/process/launch.h"
#include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
@@ -25,7 +24,6 @@
#include "base/win/windows_version.h"
#include "chrome/common/chrome_constants.h"
#include "chrome/common/chrome_switches.h"
-#include "chrome/installer/launcher_support/chrome_launcher_support.h"
#include "chrome/installer/setup/install_worker.h"
#include "chrome/installer/setup/setup_constants.h"
#include "chrome/installer/util/auto_launch_util.h"
@@ -691,15 +689,4 @@ void HandleActiveSetupForBrowser(const base::FilePath& installation_root,
chrome_exe, chrome, prefs, CURRENT_USER, install_operation);
}
-bool InstallFromWebstore(const std::string& app_code) {
huangs 2014/07/25 15:56:41 Also remove from install.h.
grt (UTC plus 2) 2014/07/25 17:17:03 Done.
- base::FilePath app_host_path(chrome_launcher_support::GetAnyAppHostPath());
- if (app_host_path.empty())
- return false;
-
- CommandLine cmd(app_host_path);
- cmd.AppendSwitchASCII(::switches::kInstallFromWebstore, app_code);
- VLOG(1) << "App install command: " << cmd.GetCommandLineString();
- return base::LaunchProcess(cmd, base::LaunchOptions(), NULL);
-}
-
} // namespace installer

Powered by Google App Engine
This is Rietveld 408576698