Issue 422443008: New avatar menu: Don't show "Go incognito" if incognito is disabled by policy

Issue 422443008: New avatar menu: Don't show "Go incognito" if incognito is disabled by policy (Closed)

Created:
6 years, 4 months ago by Marc Treib

Modified:
6 years, 4 months ago

Reviewers:
msw

CC:
chromium-reviews, tfarina, noms (inactive)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

New avatar menu: Don't show "Go incognito" if incognito is disabled by policy BUG=400094 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287543

Patch Set 3 : nit #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -10 lines)			Patch
M	chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm	View	1	5 chunks	+12 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/profiles/profile_chooser_view.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/profiles/profile_chooser_view.cc	View	1 2	5 chunks	+16 lines, -8 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

msw

lgtm with an unrelated optional nit. https://codereview.chromium.org/422443008/diff/20001/chrome/browser/ui/views/profiles/profile_chooser_view.cc File chrome/browser/ui/views/profiles/profile_chooser_view.cc (right): https://codereview.chromium.org/422443008/diff/20001/chrome/browser/ui/views/profiles/profile_chooser_view.cc#newcode829 chrome/browser/ui/views/profiles/profile_chooser_view.cc:829: void ProfileChooserView::PostActionPerformed( nit: ...

6 years, 4 months ago (2014-08-04 17:09:40 UTC) #2

Marc Treib

https://codereview.chromium.org/422443008/diff/20001/chrome/browser/ui/views/profiles/profile_chooser_view.cc File chrome/browser/ui/views/profiles/profile_chooser_view.cc (right): https://codereview.chromium.org/422443008/diff/20001/chrome/browser/ui/views/profiles/profile_chooser_view.cc#newcode829 chrome/browser/ui/views/profiles/profile_chooser_view.cc:829: void ProfileChooserView::PostActionPerformed( On 2014/08/04 17:09:40, msw wrote: > nit: ...

6 years, 4 months ago (2014-08-05 08:21:33 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/422443008/40001

6 years, 4 months ago (2014-08-05 08:24:16 UTC) #5

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...

6 years, 4 months ago (2014-08-05 14:13:33 UTC) #6

Message was sent while issue was closed.

Change committed as 287543

Expand Messages | Collapse Messages