Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 422443004: Fix incorrect number of matches and misleading highlighting in "Find on Page" results (Closed)

Created:
6 years, 5 months ago by Andrey Kraynov
Modified:
6 years, 4 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Fix incorrect number of matches and misleading highlighting in "Find on Page" results. BUG=397563 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179000

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2 lines) Patch
M Source/web/TextFinder.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/tests/TextFinderTest.cpp View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Andrey Kraynov
yosin@, could you please take a look at this CL and a bug that I've ...
6 years, 5 months ago (2014-07-25 17:16:55 UTC) #1
yosin_UTC9
LGTM Add tkent@ for OWNERS review.
6 years, 4 months ago (2014-07-28 01:03:58 UTC) #2
tkent
rslgtm
6 years, 4 months ago (2014-07-28 01:26:05 UTC) #3
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 4 months ago (2014-07-28 01:26:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iceman@yandex-team.ru/422443004/1
6 years, 4 months ago (2014-07-28 01:26:36 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-07-28 02:29:22 UTC) #6
commit-bot: I haz the power
Change committed as 179000
6 years, 4 months ago (2014-07-28 03:06:07 UTC) #7
Vladislav Kaznacheev
6 years, 4 months ago (2014-07-28 14:17:27 UTC) #8
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/424803002/ by kaznacheev@chromium.org.

The reason for reverting is: This broke FindInPageControllerTest.LargePage on
multiple bots (e.g.
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%282%29/buil...)

Filed a bug:
https://code.google.com/p/chromium/issues/detail?id=398017.

Powered by Google App Engine
This is Rietveld 408576698