Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 422393002: [Android] Fix the uiautomator test runner's use of InstrumentationOptions. (Closed)

Created:
6 years, 4 months ago by jbudorick
Modified:
6 years, 4 months ago
Reviewers:
klundberg, craigdh, frankf
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Fix the uiautomator test runner's use of InstrumentationOptions. BUG=398520 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287217

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M build/android/pylib/instrumentation/test_options.py View 1 2 chunks +1 line, -1 line 0 comments Download
M build/android/pylib/uiautomator/test_runner.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M build/android/test_runner.py View 1 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
jbudorick
broken by the addition of test_runner to InstrumentationOptions in https://codereview.chromium.org/415463002/
6 years, 4 months ago (2014-07-29 19:51:15 UTC) #1
klundberg
lgtm
6 years, 4 months ago (2014-07-29 19:56:30 UTC) #2
frankf
lgtm I thought there was a dummy test on trybots
6 years, 4 months ago (2014-07-29 19:58:01 UTC) #3
jbudorick
The CQ bit was checked by jbudorick@chromium.org
6 years, 4 months ago (2014-08-02 15:50:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbudorick@chromium.org/422393002/20001
6 years, 4 months ago (2014-08-02 15:50:31 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-02 17:02:09 UTC) #6
Message was sent while issue was closed.
Change committed as 287217

Powered by Google App Engine
This is Rietveld 408576698