Issue 42235: Make debug check in visitedlink_master.h more informative

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 42235: Make debug check in visitedlink_master.h more informative (Closed)

Created:
11 years, 9 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
tony, pfeldman

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Make debug check in visitedlink_master.h more informative by changing DCHECK to DCHECK_EQ. We're getting a lot of trouble with this check, and I just received a report on irc about problems with it even after my last visitedlink change (r11734). More information in the error message may help. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11743

Patch Set 1 #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/visitedlink_master.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

pfeldman

11 years, 9 months ago (2009-03-16 19:02:57 UTC) #2

On 2009/03/16 18:11:18, tony wrote:
> LG

FYI: The code in head does not work to me - failing in this very line.

Expand Messages | Collapse Messages