Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 422343004: Browser Plugin: Remove embedder_frame_url (Closed)

Created:
6 years, 4 months ago by Fady Samuel
Modified:
6 years, 4 months ago
Reviewers:
kenrb, Fady Samuel
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M content/common/browser_plugin/browser_plugin_messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/browser_plugin/browser_plugin.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 4 months ago (2014-07-29 17:29:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/422343004/1
6 years, 4 months ago (2014-07-29 17:30:02 UTC) #2
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-07-29 21:01:02 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-29 21:23:25 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_triggered_tests/builds/787)
6 years, 4 months ago (2014-07-29 21:23:25 UTC) #5
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 4 months ago (2014-07-30 16:29:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/422343004/1
6 years, 4 months ago (2014-07-30 16:32:23 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-07-30 16:34:02 UTC) #8
Message was sent while issue was closed. 
Change committed as 286535

Powered by Google App Engine
This is Rietveld 408576698