Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 422293004: Update memory related v8 notifications API calls (Closed)

Created:
6 years, 4 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 4 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Project:
blink
Visibility:
Public.

Description

Update memory related v8 notifications API calls The API calls are per Isolate, and therefore should be on the isolate. Make it so. BUG=397026 R=haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179155

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M Source/bindings/core/v8/ScriptProfiler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8GCForContextDispose.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/WorkerScriptController.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
jochen (gone - plz use gerrit)
6 years, 4 months ago (2014-07-29 14:37:42 UTC) #1
haraken
LGTM
6 years, 4 months ago (2014-07-29 15:36:41 UTC) #2
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 4 months ago (2014-07-29 15:41:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/422293004/1
6 years, 4 months ago (2014-07-29 15:42:23 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 15:45:38 UTC) #5
Message was sent while issue was closed.
Change committed as 179155

Powered by Google App Engine
This is Rietveld 408576698