Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 422253002: Replace forward declaration with include in default_component_installer.h (Closed)

Created:
6 years, 4 months ago by Andrew Hayden (chromium.org)
Modified:
6 years, 4 months ago
CC:
chromium-reviews, waffles, cpu_(ooo_6.6-7.5), Sorin Jianu
Project:
chromium
Visibility:
Public.

Description

Replace forward declaration with include in default_component_installer.h Because the "DictionaryValue" type is used in a scoped_ptr and scoped_ptr needs to invoke the destructor, the full definition of the class is needed at compile time. We apparently get lucky with include order on the non-Windows platforms, because this only showed up when adding a new transitive dependency upon default_component_installer.h and then only failed on Windows. Fixing this unblocks the unconditional inclusion of the cld_component_installer, which we need in order to fix crbug/367239. BUG= TBR=waffles@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286200

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/component_updater/default_component_installer.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
anton1
lgtm
6 years, 4 months ago (2014-07-29 10:57:46 UTC) #1
Andrew Hayden (chromium.org)
The CQ bit was checked by andrewhayden@chromium.org
6 years, 4 months ago (2014-07-29 11:01:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andrewhayden@chromium.org/422253002/1
6 years, 4 months ago (2014-07-29 11:03:25 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-07-29 12:54:54 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-29 14:07:37 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel/builds/910)
6 years, 4 months ago (2014-07-29 14:07:38 UTC) #6
Andrew Hayden (chromium.org)
The CQ bit was checked by andrewhayden@chromium.org
6 years, 4 months ago (2014-07-29 14:11:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andrewhayden@chromium.org/422253002/1
6 years, 4 months ago (2014-07-29 14:12:13 UTC) #8
commit-bot: I haz the power
Change committed as 286200
6 years, 4 months ago (2014-07-29 15:24:33 UTC) #9
waffles
6 years, 4 months ago (2014-07-29 16:23:37 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698