Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 422243002: Ensure public account policy wallpaper is stored in correct place. (Closed)

Created:
6 years, 4 months ago by Thiemo Nagel
Modified:
6 years, 4 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Ensure public account policy wallpaper is stored in correct place. Previously, when user_id_hash was empty, the wallpaper was stored with the wrong filename and thus couldn't be retrieved later on. Also fixes the problem that setting a wallpaper with small dimensions after a wallpaper with large dimensions didn't clear all scaled copies of the previous wallpaper. BUG=388819 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287313

Patch Set 1 #

Total comments: 5

Patch Set 2 : Fix indentation. #

Total comments: 2

Patch Set 3 : Rebase. #

Patch Set 4 : Address Alexander's comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -22 lines) Patch
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc View 1 2 3 8 chunks +47 lines, -22 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Thiemo Nagel
Hi Pavel, could you please be so kind to take a look? I've cc'ed Alexander ...
6 years, 4 months ago (2014-07-29 09:02:40 UTC) #1
bshe
https://codereview.chromium.org/422243002/diff/1/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc File chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc (left): https://codereview.chromium.org/422243002/diff/1/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc#oldcode865 chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc:865: DCHECK(UserManager::Get()->IsUserLoggedIn()); why remove this DCHECK? https://codereview.chromium.org/422243002/diff/1/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h File chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h (right): ...
6 years, 4 months ago (2014-07-29 18:54:58 UTC) #2
bshe
lgtm https://codereview.chromium.org/422243002/diff/1/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc File chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc (left): https://codereview.chromium.org/422243002/diff/1/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc#oldcode865 chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc:865: DCHECK(UserManager::Get()->IsUserLoggedIn()); hah. Just saw your other CL. The ...
6 years, 4 months ago (2014-07-29 19:01:02 UTC) #3
Thiemo Nagel
Thank you! I've fixed the indent. https://codereview.chromium.org/422243002/diff/1/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc File chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc (left): https://codereview.chromium.org/422243002/diff/1/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc#oldcode865 chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc:865: DCHECK(UserManager::Get()->IsUserLoggedIn()); On 2014/07/29 ...
6 years, 4 months ago (2014-07-30 13:29:25 UTC) #4
dzhioev (left Google)
On 2014/07/29 09:02:40, Thiemo Nagel wrote: > Hi Pavel, > > could you please be ...
6 years, 4 months ago (2014-08-01 16:30:13 UTC) #5
Alexander Alekseev
lgtm with nits. https://codereview.chromium.org/422243002/diff/20001/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc File chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc (right): https://codereview.chromium.org/422243002/diff/20001/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc#newcode1024 chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc:1024: true); nit: /* recursive */
6 years, 4 months ago (2014-08-01 19:25:45 UTC) #6
Thiemo Nagel
Thank you! https://codereview.chromium.org/422243002/diff/20001/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc File chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc (right): https://codereview.chromium.org/422243002/diff/20001/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc#newcode1024 chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc:1024: true); On 2014/08/01 19:25:45, alemate wrote: > ...
6 years, 4 months ago (2014-08-04 08:34:09 UTC) #7
Thiemo Nagel
The CQ bit was checked by tnagel@chromium.org
6 years, 4 months ago (2014-08-04 08:34:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/422243002/60001
6 years, 4 months ago (2014-08-04 08:35:09 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-04 09:59:55 UTC) #10
Message was sent while issue was closed. 
Change committed as 287313

Powered by Google App Engine
This is Rietveld 408576698