Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 422233010: Also mark as prototype when passing in while creating a function. (Closed)

Created:
6 years, 4 months ago by Toon Verwaest
Modified:
6 years, 4 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Also mark as prototype when passing in while creating a function. BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22830

Patch Set 1 #

Patch Set 2 : Don't recopy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/factory.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/objects.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 4 months ago (2014-08-04 15:19:26 UTC) #1
Igor Sheludko
lgtm
6 years, 4 months ago (2014-08-04 15:20:40 UTC) #2
Toon Verwaest
6 years, 4 months ago (2014-08-04 15:23:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as 22830 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698