Re-raster during scale animations for GPU-rasterized layers without text

Re-raster during scale animations for GPU-rasterized layers without text

This re-rasters GPU-rasterized layers during scale animations in order to
keep content crisp, but only for layers that don't have text (since
re-rastering text at different scales leads to expensive glyph texture
uploads at each scale).

BUG=395760, 372391
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291068

[enne (OOO), 2014-08-20 18:15:50]

lgtm

https://codereview.chromium.org/422233008/diff/20001/cc/layers/picture_layer_...
File cc/layers/picture_layer_impl.cc (right):

https://codereview.chromium.org/422233008/diff/20001/cc/layers/picture_layer_...
cc/layers/picture_layer_impl.cc:1311: if (pile_->has_text())
Can you add some comments about why this is needed? As far as I know, this is a
performance workaround for the fact that Ganesh is slow to reraster text at
different scales.  Is there a bug that can be linked to?

[ajuma, 2014-08-20 18:51:29]

https://codereview.chromium.org/422233008/diff/20001/cc/layers/picture_layer_...
File cc/layers/picture_layer_impl.cc (right):

https://codereview.chromium.org/422233008/diff/20001/cc/layers/picture_layer_...
cc/layers/picture_layer_impl.cc:1311: if (pile_->has_text())
On 2014/08/20 18:15:49, enne wrote:
> Can you add some comments about why this is needed? As far as I know, this is
a
> performance workaround for the fact that Ganesh is slow to reraster text at
> different scales.  Is there a bug that can be linked to?

Done.

[ajuma, 2014-08-20 18:51:34]

The CQ bit was checked by ajuma@chromium.org

[commit-bot: I haz the power, 2014-08-20 18:52:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ajuma@chromium.org/422233008/40001

[commit-bot: I haz the power, 2014-08-20 20:45:58]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[commit-bot: I haz the power, 2014-08-20 20:50:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-20 20:50:04]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[ajuma, 2014-08-20 20:51:40]

The CQ bit was checked by ajuma@chromium.org

[commit-bot: I haz the power, 2014-08-20 20:53:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ajuma@chromium.org/422233008/40001

[commit-bot: I haz the power, 2014-08-20 20:58:29]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[commit-bot: I haz the power, 2014-08-20 21:01:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-20 21:01:50]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[ajuma, 2014-08-21 13:02:20]

The CQ bit was checked by ajuma@chromium.org

[commit-bot: I haz the power, 2014-08-21 13:03:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ajuma@chromium.org/422233008/40001

[commit-bot: I haz the power, 2014-08-21 14:59:01]

Committed patchset #2 (40001) as 291068