Issue 422233003: bindings: Removes an unnecessary type conversion in V8DOMWrapper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 422233003: bindings: Removes an unnecessary type conversion in V8DOMWrapper. (Closed)

Created:
6 years, 4 months ago by Yuki

Modified:
6 years, 4 months ago

Reviewers:
haraken

CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

bindings: Removes an unnecessary type conversion in V8DOMWrapper. I don't see any reason to convert the internal pointer of type void* to Node* and convert it back to void*. BUG=235436 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179151

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	Source/bindings/core/v8/V8DOMWrapper.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/422233003/1

6 years, 4 months ago (2014-07-29 14:12:02 UTC) #4

Message was sent while issue was closed.

Change committed as 179151