Extract mojo_base.gyp from mojo.gyp

Extract mojo_base.gyp from mojo.gyp

This change extract essential part of Mojo, which is needed
to build chrome and its submodules, to mojo_base.gyp.
Other chrome submodules can safely depends on mojo_base.gyp
without worrying about excessive dependencies behind.

Caveat: mojo_service_manager stays on mojo.gyp even though
it is required to build chrome. This change leaves it
as it depends on net.gyp, which has non trivial dependencies.

BUG=397672
TEST=none
R=jamesr@chromium.org, viettrungluu@chromium.org, rockot@chromium.org
TBR=darin@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286627

[viettrungluu, 2014-07-28 22:18:53]

https://codereview.chromium.org/422163004/diff/1/mojo/mojo_base.gyp
File mojo/mojo_base.gyp (right):

https://codereview.chromium.org/422163004/diff/1/mojo/mojo_base.gyp#newcode4
mojo/mojo_base.gyp:4: 
A comment explaining what goes (or should go) in this (and its .gypi's) vs in
mojo.gyp (and its .gypi's) would be good.

https://codereview.chromium.org/422163004/diff/1/mojo/mojo_base.gyp#newcode435
mojo/mojo_base.gyp:435: #            'mojo_shell_lib',
?

https://codereview.chromium.org/422163004/diff/1/mojo/mojo_public_tests.gypi
File mojo/mojo_public_tests.gypi (right):

https://codereview.chromium.org/422163004/diff/1/mojo/mojo_public_tests.gypi#...
mojo/mojo_public_tests.gypi:178: 'target_name':
'mojo_public_application_unittests',
AFAICT, you're just reordering this file, but I'm not sure what exactly the
order is....

https://codereview.chromium.org/422163004/diff/1/mojo/mojo_variables.gypi
File mojo/mojo_variables.gypi (right):

https://codereview.chromium.org/422163004/diff/1/mojo/mojo_variables.gypi#new...
mojo/mojo_variables.gypi:1: {
Missing copyright header.

Also, it'd be helpful to have a comment explaining what this file is for (and I
guess that it's included by multiple .gyp files?).

[Hajime Morrita, 2014-07-28 22:40:40]

PTAL?

https://codereview.chromium.org/422163004/diff/1/mojo/mojo_base.gyp
File mojo/mojo_base.gyp (right):

https://codereview.chromium.org/422163004/diff/1/mojo/mojo_base.gyp#newcode4
mojo/mojo_base.gyp:4: 
On 2014/07/28 22:18:53, viettrungluu wrote:
> A comment explaining what goes (or should go) in this (and its .gypi's) vs in
> mojo.gyp (and its .gypi's) would be good.

Done.

https://codereview.chromium.org/422163004/diff/1/mojo/mojo_base.gyp#newcode435
mojo/mojo_base.gyp:435: #            'mojo_shell_lib',
On 2014/07/28 22:18:53, viettrungluu wrote:
> ?
Removed.

https://codereview.chromium.org/422163004/diff/1/mojo/mojo_public_tests.gypi
File mojo/mojo_public_tests.gypi (right):

https://codereview.chromium.org/422163004/diff/1/mojo/mojo_public_tests.gypi#...
mojo/mojo_public_tests.gypi:178: 'target_name':
'mojo_public_application_unittests',
On 2014/07/28 22:18:53, viettrungluu wrote:
> AFAICT, you're just reordering this file, but I'm not sure what exactly the
> order is....
Oops. Unintentional :-(
Reverted.

https://codereview.chromium.org/422163004/diff/1/mojo/mojo_variables.gypi
File mojo/mojo_variables.gypi (right):

https://codereview.chromium.org/422163004/diff/1/mojo/mojo_variables.gypi#new...
mojo/mojo_variables.gypi:1: {
On 2014/07/28 22:18:53, viettrungluu wrote:
> Missing copyright header.
> 
> Also, it'd be helpful to have a comment explaining what this file is for (and
I
> guess that it's included by multiple .gyp files?).

Done.

[viettrungluu, 2014-07-28 22:51:33]

mojo/ lgtm w/nits

https://codereview.chromium.org/422163004/diff/40001/mojo/mojo.gyp
File mojo/mojo.gyp (right):

https://codereview.chromium.org/422163004/diff/40001/mojo/mojo.gyp#newcode452
mojo/mojo.gyp:452: 'mojo_base.gyp:mojo_common_lib',
nit: maybe it'd be better to list all the mojo_base.gyp:... entries first (after
the ../... ones), and put them in alphabetical order?

https://codereview.chromium.org/422163004/diff/40001/mojo/mojo_apps.gypi
File mojo/mojo_apps.gypi (right):

https://codereview.chromium.org/422163004/diff/40001/mojo/mojo_apps.gypi#newc...
mojo/mojo_apps.gypi:60: 'mojo_base.gyp:mojo_run_all_unittests',
nit: alphabetical order here too

https://codereview.chromium.org/422163004/diff/40001/mojo/mojo_base.gyp
File mojo/mojo_base.gyp (right):

https://codereview.chromium.org/422163004/diff/40001/mojo/mojo_base.gyp#newcode5
mojo/mojo_base.gyp:5: #
nit (here and elsewhere): no need for blank comment lines

https://codereview.chromium.org/422163004/diff/40001/mojo/mojo_base.gyp#newcode6
mojo/mojo_base.gyp:6: # Essential components that are needed to build Chrome
should be here.
Essential components (and their tests) ...?

https://codereview.chromium.org/422163004/diff/40001/mojo/mojo_base.gyp#newcode7
mojo/mojo_base.gyp:7: # Other components that are useful only in Mojo land like
mojo_shell should be in mojo.gyp.
80-character lines.

https://codereview.chromium.org/422163004/diff/40001/mojo/mojo_examples.gypi
File mojo/mojo_examples.gypi (right):

https://codereview.chromium.org/422163004/diff/40001/mojo/mojo_examples.gypi#...
mojo/mojo_examples.gypi:14: 'mojo_base.gyp:mojo_cpp_bindings',
alphabetical order (elsewhere in this file too)

https://codereview.chromium.org/422163004/diff/40001/mojo/mojo_public.gypi
File mojo/mojo_public.gypi (right):

https://codereview.chromium.org/422163004/diff/40001/mojo/mojo_public.gypi#ne...
mojo/mojo_public.gypi:231: }
Did you remove an end-of-file newline (or something) here?

(Or add one? Adding would be okay.)

https://codereview.chromium.org/422163004/diff/40001/mojo/mojo_public_tests.gypi
File mojo/mojo_public_tests.gypi (right):

https://codereview.chromium.org/422163004/diff/40001/mojo/mojo_public_tests.g...
mojo/mojo_public_tests.gypi:105: 'mojo_utility',
alphabetical order

https://codereview.chromium.org/422163004/diff/40001/mojo/mojo_services.gypi
File mojo/mojo_services.gypi (right):

https://codereview.chromium.org/422163004/diff/40001/mojo/mojo_services.gypi#...
mojo/mojo_services.gypi:31: 'mojo_base.gyp:mojo_common_lib',
... (even if we're not actually very good at keeping dependencies in
alphabetical order)

https://codereview.chromium.org/422163004/diff/40001/mojo/mojo_variables.gypi
File mojo/mojo_variables.gypi (right):

https://codereview.chromium.org/422163004/diff/40001/mojo/mojo_variables.gypi...
mojo/mojo_variables.gypi:5: #
No need for empty comment lines.

https://codereview.chromium.org/422163004/diff/40001/mojo/mojo_variables.gypi...
mojo/mojo_variables.gypi:13: #
You can get rid of darin's empty comment lines too. :)

[Hajime Morrita, 2014-07-28 23:04:09]

Thanks!

https://codereview.chromium.org/422163004/diff/40001/mojo/mojo.gyp
File mojo/mojo.gyp (right):

https://codereview.chromium.org/422163004/diff/40001/mojo/mojo.gyp#newcode452
mojo/mojo.gyp:452: 'mojo_base.gyp:mojo_common_lib',
On 2014/07/28 22:51:32, viettrungluu wrote:
> nit: maybe it'd be better to list all the mojo_base.gyp:... entries first
(after
> the ../... ones), and put them in alphabetical order?

Done.

https://codereview.chromium.org/422163004/diff/40001/mojo/mojo_apps.gypi
File mojo/mojo_apps.gypi (right):

https://codereview.chromium.org/422163004/diff/40001/mojo/mojo_apps.gypi#newc...
mojo/mojo_apps.gypi:60: 'mojo_base.gyp:mojo_run_all_unittests',
On 2014/07/28 22:51:32, viettrungluu wrote:
> nit: alphabetical order here too

Done.

https://codereview.chromium.org/422163004/diff/40001/mojo/mojo_base.gyp
File mojo/mojo_base.gyp (right):

https://codereview.chromium.org/422163004/diff/40001/mojo/mojo_base.gyp#newcode5
mojo/mojo_base.gyp:5: #
On 2014/07/28 22:51:32, viettrungluu wrote:
> nit (here and elsewhere): no need for blank comment lines

Done.

https://codereview.chromium.org/422163004/diff/40001/mojo/mojo_base.gyp#newcode6
mojo/mojo_base.gyp:6: # Essential components that are needed to build Chrome
should be here.
On 2014/07/28 22:51:32, viettrungluu wrote:
> Essential components (and their tests) ...?

Done.

https://codereview.chromium.org/422163004/diff/40001/mojo/mojo_base.gyp#newcode7
mojo/mojo_base.gyp:7: # Other components that are useful only in Mojo land like
mojo_shell should be in mojo.gyp.
On 2014/07/28 22:51:32, viettrungluu wrote:
> 80-character lines.

Done.

https://codereview.chromium.org/422163004/diff/40001/mojo/mojo_examples.gypi
File mojo/mojo_examples.gypi (right):

https://codereview.chromium.org/422163004/diff/40001/mojo/mojo_examples.gypi#...
mojo/mojo_examples.gypi:14: 'mojo_base.gyp:mojo_cpp_bindings',
On 2014/07/28 22:51:32, viettrungluu wrote:
> alphabetical order (elsewhere in this file too)

Done.

https://codereview.chromium.org/422163004/diff/40001/mojo/mojo_public.gypi
File mojo/mojo_public.gypi (right):

https://codereview.chromium.org/422163004/diff/40001/mojo/mojo_public.gypi#ne...
mojo/mojo_public.gypi:231: }
On 2014/07/28 22:51:32, viettrungluu wrote:
> Did you remove an end-of-file newline (or something) here?
> 
> (Or add one? Adding would be okay.)
I did remove it accidentally :-(
Reverted.

[Hajime Morrita, 2014-07-28 23:05:07]

Darin: Could you rubberstamp for content/ and others?
This is just a rename for them.

[Ken Rockot(use gerrit already), 2014-07-29 05:49:22]

extensions lgtm

[Hajime Morrita, 2014-07-29 17:08:39]

The CQ bit was checked by morrita@chromium.org

[commit-bot: I haz the power, 2014-07-29 17:09:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/morrita@chromium.org/422163004/60001

[commit-bot: I haz the power, 2014-07-29 17:13:40]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[commit-bot: I haz the power, 2014-07-29 17:15:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-29 17:15:07]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[Hajime Morrita, 2014-07-29 17:29:34]

The CQ bit was checked by morrita@chromium.org

[commit-bot: I haz the power, 2014-07-29 17:31:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/morrita@chromium.org/422163004/80001

[commit-bot: I haz the power, 2014-07-29 21:22:27]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-07-30 03:04:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-30 03:04:26]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Hajime Morrita, 2014-07-30 17:44:21]

The CQ bit was checked by morrita@chromium.org

[commit-bot: I haz the power, 2014-07-30 17:45:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/morrita@chromium.org/422163004/100001

[commit-bot: I haz the power, 2014-07-30 21:02:01]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_rel on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/...)
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)

[commit-bot: I haz the power, 2014-07-30 22:54:13]

Change committed as 286627