Issue 422143005: Oilpan: Move SelectorFilter to oilpan's heap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 422143005: Oilpan: Move SelectorFilter to oilpan's heap (Closed)

Created:
6 years, 4 months ago by haraken

Modified:
6 years, 4 months ago

Reviewers:
oilpan-reviews, tkent

CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Oilpan: Move SelectorFilter to oilpan's heap This CL moves SelectorFilter::ParentStackFrame from a private section to a public section to use a WTF_ALLOW_INIT_WITH_MEM_FUNCTIONS macro. BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179079

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -7 lines)			Patch
M	Source/core/css/SelectorFilter.h	View		3 chunks	+18 lines, -7 lines	0 comments	Download
M	Source/core/css/SelectorFilter.cpp	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
M	Source/core/css/resolver/StyleResolver.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/422143005/20001

6 years, 4 months ago (2014-07-28 23:58:12 UTC) #3

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...

6 years, 4 months ago (2014-07-29 01:07:09 UTC) #4

Message was sent while issue was closed.

Change committed as 179079

Expand Messages | Collapse Messages