net/socket/ssl_client_socket_pool.cc - Issue 422063004: Certificate Transparency: Require SCTs for EV certificates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/ssl_client_socket_pool.cc

Issue 422063004: Certificate Transparency: Require SCTs for EV certificates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing pointer type and tests Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/socket/ssl_client_socket_openssl.cc ('K') | « net/socket/ssl_client_socket_pool.h ('k') | net/socket/ssl_client_socket_pool_unittest.cc » ('j') | net/url_request/url_request_context.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/socket/ssl_client_socket_pool.cc

diff --git a/net/socket/ssl_client_socket_pool.cc b/net/socket/ssl_client_socket_pool.cc

index 56df1d85d09bd587d9d334be5d072dec029f6d6c..c3b98b80a63885e58a5edbd6a9a724d0242aa9f9 100644

--- a/net/socket/ssl_client_socket_pool.cc

+++ b/net/socket/ssl_client_socket_pool.cc

@@ -197,6 +197,7 @@ SSLConnectJob::SSLConnectJob(const std::string& group_name,

context.channel_id_service,

context.transport_security_state,

context.cert_transparency_verifier,

+ context.cert_policy_enforcer,

(params->privacy_mode() == PRIVACY_MODE_ENABLED

? "pm/" + context.ssl_session_cache_shard

: context.ssl_session_cache_shard)),

@@ -634,6 +635,7 @@ SSLClientSocketPool::SSLClientSocketPool(

ChannelIDService* channel_id_service,

TransportSecurityState* transport_security_state,

CTVerifier* cert_transparency_verifier,

+ CertPolicyEnforcer* cert_policy_enforcer,

const std::string& ssl_session_cache_shard,

ClientSocketFactory* client_socket_factory,

TransportClientSocketPool* transport_pool,

@@ -661,6 +663,7 @@ SSLClientSocketPool::SSLClientSocketPool(

channel_id_service,

transport_security_state,

cert_transparency_verifier,

+ cert_policy_enforcer,

ssl_session_cache_shard),

base::Bind(

&SSLClientSocketPool::GetOrCreateSSLConnectJobMessenger,