Certificate Transparency: Require SCTs for EV certificates.

chrome/browser/net/packed_ct_ev_whitelist.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/net/packed_ct_ev_whitelist.h"
 
 #include <string.h>
 
 #include <algorithm>
 
@@ skipping 89 matching lines @@
     curr_hash += curr_diff;
 
     result.push_back(curr_hash);
   }
 
   uncompressed_list->swap(result);
   return true;
 }
 
 PackedEVCertsWhitelist::PackedEVCertsWhitelist(
-    const std::string& compressed_whitelist) {
+    const std::string& compressed_whitelist)
+    : is_whitelist_valid_(false) {
   if (!UncompressEVWhitelist(compressed_whitelist, &whitelist_)) {
     whitelist_.clear();
     return;
   }
+
+  is_whitelist_valid_ = true;

[Ryan Sleevi, 2014/12/01 15:27:55]

This doesn't seem used at all in this .cc; unnecessary? Or did you also mean to
update line 137?

Seems like this part of the change should be nuked.

[Eran Messeri, 2014/12/01 17:29:54]

My bad, this is a result of a bad merge. Removed.

 }
 
 PackedEVCertsWhitelist::~PackedEVCertsWhitelist() {
 }
 
 bool PackedEVCertsWhitelist::ContainsCertificateHash(
     const std::string& certificate_hash) const {
   DCHECK(!whitelist_.empty());
   uint64_t hash_to_lookup;
 
   base::ReadBigEndian(certificate_hash.data(), &hash_to_lookup);
   return bsearch(&hash_to_lookup,
                  &whitelist_[0],
                  whitelist_.size(),
                  kCertHashLength,
                  TruncatedHashesComparator) != NULL;
 }
 
 bool PackedEVCertsWhitelist::IsValid() const {
   return whitelist_.size() > 0;
 }