Certificate Transparency: Require SCTs for EV certificates.

net/cert/multi_log_ct_verifier.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_CERT_MULTI_LOG_CT_VERIFIER_H_
 #define NET_CERT_MULTI_LOG_CT_VERIFIER_H_
 
 #include <map>
 #include <string>
 
@@ skipping 18 matching lines @@
 // AddLog should be called with a CTLogVerifier (which is created from the
 // log's public key).
 class NET_EXPORT MultiLogCTVerifier : public CTVerifier {
  public:
   MultiLogCTVerifier();
   virtual ~MultiLogCTVerifier();
 
   void AddLog(scoped_ptr<CTLogVerifier> log_verifier);
   void AddLogs(ScopedVector<CTLogVerifier> log_verifiers);
 
+  void SetEnforceCTEVPolicy(bool enforce_policy);
+
   // CTVerifier implementation:
   virtual int Verify(X509Certificate* cert,
                      const std::string& stapled_ocsp_response,
                      const std::string& sct_list_from_tls_extension,
                      ct::CTVerifyResult* result,
                      const BoundNetLog& net_log) OVERRIDE;
 
+  virtual bool DoesConformToCTEVPolicy(
+      X509Certificate* cert,
+      const ct::CTVerifyResult& ct_result) OVERRIDE;

[Ryan Sleevi, 2014/08/05 22:19:10]

I see nothing that requires this to hang off the CT verifier. There's no special
access to members.

In terms of single-responsibility, I'd rather keep Chrome's specific policies on
validated SCTs + chains independent of the ability to check/validate SCTs.

[Eran Messeri, 2014/10/20 17:26:30]

The number of logs is necessary - but I can make the CTVerifier return that
information.

+
  private:
   // Mapping from a log's ID to the verifier for this log.
   // A log's ID is the SHA-256 of the log's key, as defined in section 3.2.
   // of RFC6962.
   typedef std::map<std::string, linked_ptr<CTLogVerifier> > IDToLogMap;
 
   // Verify a list of SCTs from |encoded_sct_list| over |expected_entry|,
   // placing the verification results in |result|. The SCTs in the list
   // come from |origin| (as will be indicated in the origin field of each SCT).
   bool VerifySCTs(const std::string& encoded_sct_list,
                   const ct::LogEntry& expected_entry,
                   ct::SignedCertificateTimestamp::Origin origin,
                   ct::CTVerifyResult* result);
 
   // Verifies a single, parsed SCT against all logs.
   bool VerifySingleSCT(
       scoped_refptr<ct::SignedCertificateTimestamp> sct,
       const ct::LogEntry& expected_entry,
       ct::CTVerifyResult* result);
 
   IDToLogMap logs_;
+  bool enforce_ct_ev_policy_;
 
   DISALLOW_COPY_AND_ASSIGN(MultiLogCTVerifier);
 };
 
 }  // namespace net
 
 #endif  // NET_CERT_MULTI_LOG_CT_VERIFIER_H_