Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 422023007: Use exitFullscreen(), not fullyExitFullscreen(), in HTMLMediaElement (Closed)

Created:
6 years, 4 months ago by philipj_slow
Modified:
6 years, 4 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, nessy, vcarbune.chromium
Project:
blink
Visibility:
Public.

Description

Use exitFullscreen(), not fullyExitFullscreen(), in HTMLMediaElement For both <video controls> and HTMLVideoElement.webkitExitFullscreen() it makes more sense to only exit one level of fullscreen. There was no test coverage for the distinction, and it's very unlikely that Web content could meaningfully depend on this. BUG=399556 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179440

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/html/HTMLMediaElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
philipj_slow
PTAL
6 years, 4 months ago (2014-08-01 15:45:21 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm
6 years, 4 months ago (2014-08-01 15:49:40 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 4 months ago (2014-08-01 16:39:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/422023007/1
6 years, 4 months ago (2014-08-01 16:40:45 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-01 17:57:10 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-01 19:04:55 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/19127)
6 years, 4 months ago (2014-08-01 19:04:56 UTC) #7
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 4 months ago (2014-08-02 04:32:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/422023007/1
6 years, 4 months ago (2014-08-02 04:32:40 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-02 05:39:34 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-02 06:45:10 UTC) #11
Message was sent while issue was closed.
Change committed as 179440

Powered by Google App Engine
This is Rietveld 408576698