Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Issue 422023002: DevTools: NOOP if outline dialog is not available for the content type (Closed)

Created:
6 years, 4 months ago by lushnikov
Modified:
6 years, 4 months ago
Reviewers:
apavlov, vsevik, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: NOOP if outline dialog is not available for the content type Currently hitting Ctrl-Shift-O on any typescript/python/C++ file in DevTools will result in opened bookmarks tab (at least on linux). Almost all the time, if user is editing code in Sources Panel and hitting Ctrl-Shift-O, he expects outline dialog to be shown. As we are not capable of supporting all the fancy file formats yet, the patch suggests swallowing Ctrl-Shift-O for those content types that we do not support. R=vsevik, apavlov, pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179049

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M Source/devtools/front_end/sources/SourcesView.js View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
lushnikov
6 years, 4 months ago (2014-07-28 12:29:29 UTC) #1
apavlov
https://codereview.chromium.org/422023002/diff/1/Source/devtools/front_end/sources/SourcesView.js File Source/devtools/front_end/sources/SourcesView.js (right): https://codereview.chromium.org/422023002/diff/1/Source/devtools/front_end/sources/SourcesView.js#newcode615 Source/devtools/front_end/sources/SourcesView.js:615: return true; default: return true; seems more readable. It's ...
6 years, 4 months ago (2014-07-28 12:37:53 UTC) #2
lushnikov
https://codereview.chromium.org/422023002/diff/1/Source/devtools/front_end/sources/SourcesView.js File Source/devtools/front_end/sources/SourcesView.js (right): https://codereview.chromium.org/422023002/diff/1/Source/devtools/front_end/sources/SourcesView.js#newcode615 Source/devtools/front_end/sources/SourcesView.js:615: return true; On 2014/07/28 12:37:53, apavlov wrote: > default: ...
6 years, 4 months ago (2014-07-28 14:03:09 UTC) #3
vsevik
lgtm We should implement this through a ShortcutRegistry. Let's land this one for now though.
6 years, 4 months ago (2014-07-28 15:59:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/422023002/20001
6 years, 4 months ago (2014-07-28 16:00:32 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-07-28 17:14:01 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-07-28 17:43:46 UTC) #7
Message was sent while issue was closed.
Change committed as 179049

Powered by Google App Engine
This is Rietveld 408576698