Issue 422013002: Removed IdleGlobalGC and just perform IdleNotification when incremental marking is on.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 422013002: Removed IdleGlobalGC and just perform IdleNotification when incremental marking is on. (Closed)

Created:
6 years, 4 months ago by Hannes Payer (out of office)

Modified:
6 years, 4 months ago

Reviewers:
jochen (gone - plz use gerrit), ernstm, Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Removed IdleGlobalGC and just perform IdleNotification when incremental marking is on. BUG=397026 LOG=n R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22647

Patch Set 1 #

Total comments: 2

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -67 lines)			Patch
	M	src/heap.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
	M	src/heap.cc	View		3 chunks	+3 lines, -64 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

https://codereview.chromium.org/422013002/diff/1/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/422013002/diff/1/src/heap.cc#newcode4258 src/heap.cc:4258: if (!FLAG_incremental_marking) return true; why not return false (meaning ...

6 years, 4 months ago (2014-07-28 13:11:13 UTC) #2

Hannes Payer (out of office)

6 years, 4 months ago (2014-07-28 13:56:49 UTC) #3

Hannes Payer (out of office)

6 years, 4 months ago (2014-07-28 14:18:47 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r22647 (tree was closed).

Expand Messages | Collapse Messages