Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 422003: linux: fix a warning in the process_util unittest (Closed)

Created:
11 years, 1 month ago by Evan Martin
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

linux: fix a warning in the process_util unittest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32648

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M base/process_util_unittest.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Evan Martin
11 years, 1 month ago (2009-11-20 19:31:24 UTC) #1
vandebo (ex-Chrome)
LGTM I don't know what the chrome convention is for this case. I'd normally fix ...
11 years, 1 month ago (2009-11-20 19:48:52 UTC) #2
Evan Martin
I like your idea better.
11 years, 1 month ago (2009-11-20 19:56:25 UTC) #3
Hironori Bono
11 years, 1 month ago (2009-11-24 01:54:43 UTC) #4
On 2009/11/20 19:48:52, vandebo wrote:
> I don't know what the chrome convention is for this case.  I'd normally fix
this with '(void) posix_memalign(...'

A "warn_unused_result" attribute makes gcc to output a warning when the return
value is NOT USED. As you can imagine, casting the return value to void
explicitly declares we don't use the return value. So, it cannot stop this
warning. (Fortunately or unfortunately, gcc 4.4 is very clever and strict.)

Regards,

Hironori Bono

Powered by Google App Engine
This is Rietveld 408576698