Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 4220005: [Mac] Add a confirm to quit experiment to about:flags. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <iterator> 8 #include <iterator>
9 #include <map> 9 #include <map>
10 #include <set> 10 #include <set>
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
136 kOsAll, 136 kOsAll,
137 switches::kEnablePrintPreview 137 switches::kEnablePrintPreview
138 }, 138 },
139 { 139 {
140 "dns-server", 140 "dns-server",
141 IDS_FLAGS_DNS_SERVER_NAME, 141 IDS_FLAGS_DNS_SERVER_NAME,
142 IDS_FLAGS_DNS_SERVER_DESCRIPTION, 142 IDS_FLAGS_DNS_SERVER_DESCRIPTION,
143 kOsLinux, 143 kOsLinux,
144 switches::kDnsServer 144 switches::kDnsServer
145 }, 145 },
146 {
147 "confirm-to-quit", // Do not change; see above.
viettrungluu 2010/11/02 17:28:13 One might complain that the "see above" part is a
Nico 2010/11/03 17:55:27 Can you elaborate on this untenable accusation?
148 IDS_FLAGS_CONFIRM_TO_QUIT_NAME,
149 IDS_FLAGS_CONFIRM_TO_QUIT_DESCRIPTION,
150 kOsMac,
151 switches::kEnableConfirmToQuit
152 },
146 }; 153 };
147 154
148 const Experiment* experiments = kExperiments; 155 const Experiment* experiments = kExperiments;
149 size_t num_experiments = arraysize(kExperiments); 156 size_t num_experiments = arraysize(kExperiments);
150 157
151 // Stores and encapsulates the little state that about:flags has. 158 // Stores and encapsulates the little state that about:flags has.
152 class FlagsState { 159 class FlagsState {
153 public: 160 public:
154 FlagsState() : needs_restart_(false) {} 161 FlagsState() : needs_restart_(false) {}
155 void ConvertFlagsToSwitches(PrefService* prefs, CommandLine* command_line); 162 void ConvertFlagsToSwitches(PrefService* prefs, CommandLine* command_line);
(...skipping 246 matching lines...) Expand 10 before | Expand all | Expand 10 after
402 num_experiments = arraysize(kExperiments); 409 num_experiments = arraysize(kExperiments);
403 } else { 410 } else {
404 experiments = e; 411 experiments = e;
405 num_experiments = count; 412 num_experiments = count;
406 } 413 }
407 } 414 }
408 415
409 } // namespace testing 416 } // namespace testing
410 417
411 } // namespace about_flags 418 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698