Chromium Code Reviews
Help | Chromium Project | Sign in
(288)

Issue 4220005: [Mac] Add a confirm to quit experiment to about:flags. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 5 months ago by rsesek
Modified:
2 years, 11 months ago
CC:
chromium-reviews_chromium.org, PaweĊ‚ Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

[Mac] Add a confirm to quit experiment to about:flags.

BUG=27786, 60591
TEST=Enable 'Confirm to Quit' in about:flags. When you press Cmd+Q, it brings up the floaty panel telling you to hold the key combo. When you do, it quits after 1.5 seconds.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64920

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 14

Patch Set 3 : Address comments #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+571 lines, -0 lines) Lint Patch
M chrome/app/generated_resources.grd View 1 2 2 chunks +10 lines, -0 lines 0 comments ? errors Download
A chrome/app/nibs/ConfirmQuitPanel.xib View 1 chunk +333 lines, -0 lines 0 comments ? errors Download
M chrome/browser/about_flags.cc View 1 2 1 chunk +7 lines, -0 lines 2 comments ? errors Download
M chrome/browser/app_controller_mac.mm View 1 2 3 chunks +93 lines, -0 lines 3 comments ? errors Download
A chrome/browser/cocoa/confirm_quit_panel_controller.h View 1 chunk +24 lines, -0 lines 0 comments ? errors Download
A chrome/browser/cocoa/confirm_quit_panel_controller.mm View 1 chunk +69 lines, -0 lines 0 comments ? errors Download
A chrome/browser/cocoa/confirm_quit_panel_controller_unittest.mm View 1 2 1 chunk +26 lines, -0 lines 0 comments ? errors Download
M chrome/chrome_browser.gypi View 1 2 2 chunks +3 lines, -0 lines 0 comments ? errors Download
M chrome/chrome_dll.gypi View 1 chunk +1 line, -0 lines 0 comments ? errors Download
M chrome/chrome_tests.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments ? errors Download
M chrome/common/chrome_switches.h View 1 2 1 chunk +1 line, -0 lines 0 comments ? errors Download
M chrome/common/chrome_switches.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments 0 errors Download
Commit:

Messages

Total messages: 8
rsesek
3 years, 5 months ago #1
rsesek
Screen shot: http://cl.ly/7b3985d7ad4f7b9b8ac4
3 years, 5 months ago #2
pink
No major problems, just small things. http://codereview.chromium.org/4220005/diff/8001/9004 File chrome/browser/app_controller_mac.mm (right): http://codereview.chromium.org/4220005/diff/8001/9004#newcode246 chrome/browser/app_controller_mac.mm:246: // Check if ...
3 years, 5 months ago #3
rsesek
Addressed all comments. http://codereview.chromium.org/4220005/diff/8001/9004 File chrome/browser/app_controller_mac.mm (right): http://codereview.chromium.org/4220005/diff/8001/9004#newcode246 chrome/browser/app_controller_mac.mm:246: // Check if the user really ...
3 years, 5 months ago #4
viettrungluu
LGTM, other than my probably-ill-founded fears. http://codereview.chromium.org/4220005/diff/14001/15003 File chrome/browser/about_flags.cc (right): http://codereview.chromium.org/4220005/diff/14001/15003#newcode147 chrome/browser/about_flags.cc:147: "confirm-to-quit", // Do ...
3 years, 5 months ago #5
pink
lgtm, thanks for writing that design doc.
3 years, 5 months ago #6
rsesek
http://codereview.chromium.org/4220005/diff/14001/15004 File chrome/browser/app_controller_mac.mm (right): http://codereview.chromium.org/4220005/diff/14001/15004#newcode307 chrome/browser/app_controller_mac.mm:307: do { On 2010/11/02 17:28:13, viettrungluu wrote: > Generically, ...
3 years, 5 months ago #7
Nico (ooo Apr 18 - Apr 20)
3 years, 5 months ago #8
http://codereview.chromium.org/4220005/diff/14001/15003
File chrome/browser/about_flags.cc (right):

http://codereview.chromium.org/4220005/diff/14001/15003#newcode147
chrome/browser/about_flags.cc:147: "confirm-to-quit",   // Do not change; see
above.
On 2010/11/02 17:28:13, viettrungluu wrote:
> One might complain that the "see above" part is a total tease. I blame thakis.

Can you elaborate on this untenable accusation?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6